-
Notifications
You must be signed in to change notification settings - Fork 961
Open
Labels
consensusAn issue/PR that touches consensus code, such as state_processing or block verification.An issue/PR that touches consensus code, such as state_processing or block verification.fork-choicegloasspec_changeA change related to the Eth2 specA change related to the Eth2 spec
Description
Description
While updating to consensus-spec-tests v1.7.0-alpha.1 for Gloas (#8688), we encountered failures in fork choice tests on earlier forks:
Failing tests:
fork_choice_get_head- voting_source_beyond_two_epoch (Altair)fork_choice_on_block- similar failures
Root cause:
The spec has been updated here to add a proposer index check before applying proposer boost
The new logic in update_proposer_boost_root (phase0/fork-choice.md) requires:
if is_timely and is_first_block:
head_state = copy(store.block_states[get_head(store)])
# ... advance head_state to current slot ...
if block.proposer_index == get_beacon_proposer_index(head_state):
store.proposer_boost_root = rootMetadata
Metadata
Assignees
Labels
consensusAn issue/PR that touches consensus code, such as state_processing or block verification.An issue/PR that touches consensus code, such as state_processing or block verification.fork-choicegloasspec_changeA change related to the Eth2 specA change related to the Eth2 spec