fix(gossipsub): race condition for messages already on the network

There is a possible race condition that can happen that results in us inadvertently penalizing a peer.

1.   Message A gets published on the network
1.   We receive an IHAVE for message A
1.   We request an IWANT for message from Peer Z
1.   We then publish message A
1.   Peer Z responds with our requested message, but we ignore it as its now a duplicate
1.   We penalize Peer Z for not responding to our IWANT.

This PR removes the promise for a message when we publish it.

Pull-Request: libp2p#5928.

Author: AgeManning

protocols/gossipsub/CHANGELOG.md

@@ -1,11 +1,14 @@
 ## 0.49.0
 
-- Improve error messaging by renaming `PublishError::InsufficientPeers` to 
-  `PublishError::NoPeersSubscribedToTopic`. This change makes it clearer that the error occurs 
-  specifically when trying to publish to a topic with no subscribed peers, rather than a general 
+- Fix a race condition for messages published which are already in the network.
+  See [PR 5928](https://github.com/libp2p/rust-libp2p/pull/5928)
+
+- Improve error messaging by renaming `PublishError::InsufficientPeers` to
+  `PublishError::NoPeersSubscribedToTopic`. This change makes it clearer that the error occurs
+  specifically when trying to publish to a topic with no subscribed peers, rather than a general
   peer availability issue.
   See [PR 5912](https://github.com/libp2p/rust-libp2p/pull/5912)
-  
+
 - Allow whitelisting topics for metrics to ensure metrics are recorded correctly for these topics.
   See [PR 5895](https://github.com/libp2p/rust-libp2p/pull/5895)
 

protocols/gossipsub/src/behaviour.rs

@@ -732,6 +732,9 @@ where
         self.duplicate_cache.insert(msg_id.clone());
         self.mcache.put(&msg_id, raw_message.clone());
 
+        // Consider the message as delivered for gossip promises.
+        self.gossip_promises.message_delivered(&msg_id);
+
         // If the message is anonymous or has a random author add it to the published message ids
         // cache.
         if let PublishConfig::RandomAuthor | PublishConfig::Anonymous = self.publish_config {