set empty string as defaults for codefresh's optional fields (#1777)

* set empty string as defaults for codefresh's optional fields

Signed-off-by: Javan lacerda <[email protected]>

* adding test case for empty default value

Signed-off-by: Javan lacerda <[email protected]>

* Require account_name and pipeline_name

Always present in token

Signed-off-by: Hayden B <[email protected]>

---------

Signed-off-by: Javan lacerda <[email protected]>
Signed-off-by: Hayden B <[email protected]>
Co-authored-by: Hayden B <[email protected]>

Author: javanlacerda

config/identity/config.yaml

@@ -203,6 +203,9 @@ ci-issuer-metadata:
       # for cases that the claimed data doesn't exist.
       # platform_url: Codefresh platform url
       platform_url: "https://g.codefresh.io"
+      scm_repo_url: ""
+      scm_ref: ""
+      runner_environment: ""
     extension-templates:
       # workflow_id: The ID of the specific workflow authorized in the claim.
       # For example, 64f447c02199f903000gh20.

pkg/identity/ciprovider/principal_test.go

@@ -247,6 +247,7 @@ func TestApplyTemplateOrReplace(t *testing.T) {
 		"url":         "https://github.com",
 		"claim_foo":   "default",
 		"default_foo": "default_bar",
+		"empty_value": "",
 	}
 
 	tests := map[string]struct {
@@ -309,6 +310,11 @@ func TestApplyTemplateOrReplace(t *testing.T) {
 			ExpectedResult: "bar",
 			ExpectErr:      false,
 		},
+		`Should return empty string for empty default`: {
+			Template:       "{{ .empty_value }}/123",
+			ExpectedResult: "/123",
+			ExpectErr:      false,
+		},
 	}
 
 	for name, test := range tests {