Clean up unix socket (#739)

* Clean up unix socket

On MacOS it seems subsequent attempts to bind to the abstract Unix
socket fail without first explicitly removing it. This issue seems to be
MacOS-specific as it doesn't occur on an Ubuntu VM (using `lima`).

Fixes #738

Signed-off-by: Paul Thomson <[email protected]>

* Add condition around socket file removal

MacOS doesn't have abstract unix domain sockets, and so creates a file
in the local dir which isn't removed when the server stops (due to the
handling of sockets beginning with '@')

This file needs to be removed on subsequent runs otherwise there's a
bind error

Signed-off-by: Paul Thomson <[email protected]>

Signed-off-by: Paul Thomson <[email protected]>

Author: pauldthomson

cmd/app/grpc.go

@@ -19,6 +19,8 @@ import (
 	"context"
 	"fmt"
 	"net"
+	"os"
+	"runtime"
 
 	"github.com/goadesign/goa/grpc/middleware"
 	ctclient "github.com/google/certificate-transparency-go/client"
@@ -108,6 +110,14 @@ func (g *grpcServer) startTCPListener() {
 
 func (g *grpcServer) startUnixListener() {
 	go func() {
+		if runtime.GOOS != "linux" {
+			// As MacOS doesn't have abstract unix domain sockets the file
+			// created by a previous run needs to be explicitly removed
+			if err := os.RemoveAll(LegacyUnixDomainSocket); err != nil {
+				log.Logger.Fatal(err)
+			}
+		}
+
 		unixAddr, err := net.ResolveUnixAddr("unix", LegacyUnixDomainSocket)
 		if err != nil {
 			log.Logger.Fatal(err)