Log messages show up as a text payload rather than structured data

[haydentherapper]

Description

Version

e.g. https://cloudlogging.app.goo.gl/4yEFQmHFvrijK1beA

Happening on v0.1.9, the latest at the time of filing.

[jku]

rekor-tiles own logging seems a little structured, e.g.:

jsonPayload: {
  error: "add entry: await: context canceled"
  message: "failed to integrate entry"
}

For grpcs errors, we just need to set the grpclog logger I think -- unfortunately they don't provide a slog implementation so it looks like we'd have to provide the adapter (a grpclog.LoggerV2 implementation that calls the various slog methods and would have to try to structure the output as json).

I can try this if it seems worth the work (and if no-one has a better idea) but it seems unappealing.

[jku]

if no-one has a better idea

actually there is a LoggerV2Config that can configure json output ... it is not exposed in the public API but there is an undocumented environment value that (based on code) should set that config:

GRPC_GO_LOG_FORMATTER=json

Is there an easy way to trigger a grpc error to test this out?

[jku]

That said, it's not just grpc, the tessera logging seems unstructured too:

Example:
integrateEntriesJob: spanner: code = "DeadlineExceeded", desc = "context deadline exceeded, transaction outcome unknown", requestID = "1.bd70d423a48731ae.1.3.13503817.1"

I don't think there's really any structured errors in tessera though so we probably can't do much about this (the example looks pretty structured probably because most of it it really comes from spanner)

[bobcallaway]

That said, it's not just grpc, the tessera logging seems unstructured too:

Example: integrateEntriesJob: spanner: code = "DeadlineExceeded", desc = "context deadline exceeded, transaction outcome unknown", requestID = "1.bd70d423a48731ae.1.3.13503817.1"

I don't think there's really any structured errors in tessera though so we probably can't do much about this (the example looks pretty structured probably because most of it it really comes from spanner)

this is because tessera uses klog (i dont know why) instead of a structured logging approach. This is probably the best we can do barring convincing the tf team to use a different logging approach.