support nested structs and pointers (#23)

* add support for pointer parameters in functions

* add nested struct and pointers capability, add tests

Author: siherrmann

core/runner.go

@@ -38,7 +38,7 @@ func NewRunner(options *model.Options, task interface{}, parameters ...interface
 	for i, param := range parameters {
 		paramConverted, err := vh.AnyToType(param, taskInputParameters[i])
 		if err != nil {
-			return nil, fmt.Errorf("parameter %d of task must be of type %s, got %s", i, taskInputParameters[i].Kind(), reflect.TypeOf(param).Kind())
+			return nil, fmt.Errorf("error converting parameter %d to type %s: %v", i, taskInputParameters[i].Kind(), err)
 		}
 		parameters[i] = paramConverted
 	}

core/runner_test.go

@@ -438,6 +438,13 @@ type TestData struct {
 	Active  bool
 }
 
+// Nested struct that contains both a struct and pointer to struct
+type NestedStruct struct {
+	Config   TestConfig
+	DataPtr  *TestData
+	Metadata string
+}
+
 // Task function that accepts a struct and pointer to struct
 func taskWithStructParams(config TestConfig, data *TestData) (string, error) {
 	if data == nil {
@@ -446,6 +453,14 @@ func taskWithStructParams(config TestConfig, data *TestData) (string, error) {
 	return fmt.Sprintf("%s-%d: %s (ID: %d, Active: %t)", config.Name, config.Value, data.Message, data.ID, data.Active), nil
 }
 
+// Task function that accepts a nested struct with both struct and pointer fields
+func taskWithNestedStruct(nested NestedStruct) (string, error) {
+	if nested.DataPtr == nil {
+		return "", fmt.Errorf("nested.DataPtr cannot be nil")
+	}
+	return fmt.Sprintf("%s: %s-%d | %s (ID: %d, Active: %t)", nested.Metadata, nested.Config.Name, nested.Config.Value, nested.DataPtr.Message, nested.DataPtr.ID, nested.DataPtr.Active), nil
+}
+
 // TestNewRunnerWithStructParameters tests the runner with struct and pointer-to-struct parameters
 func TestNewRunnerWithStructParameters(t *testing.T) {
 	tests := []struct {
@@ -560,3 +575,111 @@ func TestNewRunnerWithStructParameters(t *testing.T) {
 		})
 	}
 }
+
+// TestNewRunnerWithNestedStruct tests the runner with nested structs containing both struct and pointer fields
+func TestNewRunnerWithNestedStruct(t *testing.T) {
+	tests := []struct {
+		name       string
+		param      interface{}
+		wantErr    bool
+		wantResult string
+	}{
+		{
+			name: "Direct Nested Struct with Struct and Pointer",
+			param: NestedStruct{
+				Config: TestConfig{
+					Name:  "nested-config",
+					Value: 100,
+				},
+				DataPtr: &TestData{
+					ID:      10,
+					Message: "nested data",
+					Active:  true,
+				},
+				Metadata: "meta-direct",
+			},
+			wantErr:    false,
+			wantResult: "meta-direct: nested-config-100 | nested data (ID: 10, Active: true)",
+		},
+		{
+			name: "Map to Nested Struct Conversion",
+			param: map[string]interface{}{
+				"Config": map[string]interface{}{
+					"Name":  "map-config",
+					"Value": 200,
+				},
+				"DataPtr": map[string]interface{}{
+					"ID":      20,
+					"Message": "map data",
+					"Active":  false,
+				},
+				"Metadata": "meta-from-map",
+			},
+			wantErr:    false,
+			wantResult: "meta-from-map: map-config-200 | map data (ID: 20, Active: false)",
+		},
+		{
+			name: "Map with Type Conversions in Nested Struct",
+			param: map[string]interface{}{
+				"Config": map[string]interface{}{
+					"Name":  "type-conv",
+					"Value": 300.5, // float64 to int
+				},
+				"DataPtr": map[string]interface{}{
+					"ID":      30.0, // float64 to int
+					"Message": "type conversion",
+					"Active":  true,
+				},
+				"Metadata": "meta-type-conv",
+			},
+			wantErr:    false,
+			wantResult: "meta-type-conv: type-conv-300 | type conversion (ID: 30, Active: true)",
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			mockTask, err := model.NewTask(taskWithNestedStruct)
+			require.NoError(t, err, "Failed to create mock task")
+
+			job := &model.Job{
+				TaskName: mockTask.Name,
+				Parameters: []interface{}{
+					test.param,
+				},
+				Options: &model.Options{
+					OnError: &model.OnError{
+						Timeout: 5.0,
+					},
+				},
+			}
+
+			runner, err := NewRunnerFromJob(mockTask, job)
+			if test.wantErr {
+				assert.Error(t, err, "NewRunnerFromJob should return an error")
+				return
+			}
+
+			require.NoError(t, err, "NewRunnerFromJob should not return an error")
+			assert.NotNil(t, runner)
+
+			go runner.Run(context.Background())
+
+		outerLoop:
+			for {
+				select {
+				case err := <-runner.ErrorChannel:
+					assert.NoError(t, err, "Runner should not return an error")
+					break outerLoop
+				case results := <-runner.ResultsChannel:
+					assert.NotNil(t, results)
+					assert.Len(t, results, 1)
+					assert.Equal(t, test.wantResult, results[0])
+					break outerLoop
+				case <-time.After(2 * time.Second):
+					t.Fatal("Test timed out")
+				}
+			}
+		})
+	}
+}

go.mod

@@ -68,7 +68,7 @@ require (
 	github.com/power-devops/perfstat v0.0.0-20240221224432-82ca36839d55 // indirect
 	github.com/shirou/gopsutil/v4 v4.25.10 // indirect
 	github.com/siherrmann/queuerSql v0.0.0-20251130135331-9ed23b19fae5
-	github.com/siherrmann/validator v0.11.0
+	github.com/siherrmann/validator v0.12.0
 	github.com/sirupsen/logrus v1.9.3 // indirect
 	github.com/spf13/cobra v1.10.1
 	github.com/tklauser/go-sysconf v0.3.16 // indirect

go.sum

@@ -127,8 +127,8 @@ github.com/rogpeppe/go-internal v1.14.1/go.mod h1:MaRKkUm5W0goXpeCfT7UZI6fk/L7L7
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/shirou/gopsutil/v4 v4.25.10 h1:at8lk/5T1OgtuCp+AwrDofFRjnvosn0nkN2OLQ6g8tA=
 github.com/shirou/gopsutil/v4 v4.25.10/go.mod h1:+kSwyC8DRUD9XXEHCAFjK+0nuArFJM0lva+StQAcskM=
-github.com/siherrmann/validator v0.11.0 h1:DTLzGvwZUJwhr842xZkX/m7ed4DMFKJ9AKoYDk4+cNs=
-github.com/siherrmann/validator v0.11.0/go.mod h1:LqNNViIg5YKzO4SX4zMdafyffL6xCWuRqSyt1szpolo=
+github.com/siherrmann/validator v0.12.0 h1:bW80s6cXVuqIYPWCB8nboXryJWVog1C+XOQW72XovbE=
+github.com/siherrmann/validator v0.12.0/go.mod h1:LqNNViIg5YKzO4SX4zMdafyffL6xCWuRqSyt1szpolo=
 github.com/sirupsen/logrus v1.9.3 h1:dueUQJ1C2q9oE3F7wvmSGAaVtTmUizReu6fjN8uqzbQ=
 github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVsIT4qYEQ=
 github.com/spf13/cobra v1.10.1 h1:lJeBwCfmrnXthfAupyUTzJ/J4Nc1RsHC/mSRU2dll/s=