update start time for scheduler

Author: siherrmann

core/runner_test.go

@@ -365,27 +365,31 @@ func TestCancelMethodWithOnCancelFunc(t *testing.T) {
 	runner, err := NewRunnerFromJob(mockTask, job)
 	require.NoError(t, err)
 
-	called := make(chan bool, 1)
-
-	go runner.Run(context.Background())
+	ready := make(chan struct{})
+	go func() {
+		close(ready)
+		runner.Run(context.Background())
+	}()
 
+	<-ready
+	called := make(chan bool, 1)
 	go func() {
-		time.Sleep(50 * time.Millisecond)
+		time.Sleep(500 * time.Millisecond)
 		runner.Cancel(func() {
 			called <- true
-		}) // Call with callback
+		})
 	}()
 
 outerLoop:
 	for {
 		select {
 		case err := <-runner.ErrorChannel:
-			assert.Error(t, err)
+			assert.Error(t, err, "Runner should return an error on cancel")
 			assert.Equal(t, <-called, true, "onCancelFunc should have been called")
-			assert.Contains(t, err.Error(), "canceled")
+			assert.Contains(t, err.Error(), "canceled", "Error should indicate cancellation")
 			break outerLoop
 		case results := <-runner.ResultsChannel:
-			assert.Nil(t, results)
+			assert.Nil(t, results, "Results should be nil on cancel")
 			break outerLoop
 		}
 	}

core/scheduler_test.go

@@ -11,7 +11,7 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-const maxDeviation = 100 * time.Millisecond
+const maxDeviation = 500 * time.Millisecond
 
 // funcScheduler is a mock function type that can be passed to Scheduler.
 type funcScheduler struct {
@@ -110,11 +110,12 @@ func TestScheduleWithDelay(t *testing.T) {
 	scheduler, err := NewScheduler(&startTime, mockFn.Call)
 	require.NoError(t, err)
 
-	start := time.Now()
 	scheduler.Go(context.Background())
 
+	var start time.Time
 	done := make(chan bool)
 	go func() {
+		start = time.Now()
 		mockFn.wg.Wait()
 		done <- true
 	}()
@@ -138,11 +139,12 @@ func TestScheduleTimeInPast(t *testing.T) {
 	scheduler, err := NewScheduler(&startTime, mockFn.Call)
 	require.NoError(t, err)
 
-	start := time.Now()
 	scheduler.Go(context.Background())
 
+	var start time.Time
 	done := make(chan bool)
 	go func() {
+		start = time.Now()
 		mockFn.wg.Wait()
 		done <- true
 	}()
@@ -165,11 +167,12 @@ func TestScheduleNoDelay(t *testing.T) {
 	scheduler, err := NewScheduler(&now, mockFn.Call)
 	require.NoError(t, err)
 
-	start := time.Now()
 	scheduler.Go(context.Background())
 
+	var start time.Time
 	done := make(chan bool)
 	go func() {
+		start = time.Now()
 		mockFn.wg.Wait()
 		done <- true
 	}()
@@ -194,11 +197,12 @@ func TestScheduleWithWorkDuration(t *testing.T) {
 	scheduler, err := NewScheduler(&startTime, mockFn.Call)
 	require.NoError(t, err)
 
-	start := time.Now()
 	scheduler.Go(context.Background())
 
+	var start time.Time
 	done := make(chan bool)
 	go func() {
+		start = time.Now()
 		mockFn.wg.Wait()
 		done <- true
 	}()