nodiscard ChipError Batch #4: non-clusters app code (#41862)

* Batch #4 nodiscard errors: non-clusters app code

* Fix clang

Author: gmarcosb

src/app/AttributeValueEncoder.cpp

@@ -89,11 +89,11 @@ void AttributeValueEncoder::EnsureListEnded()
     // fails, because that would mean that we've corrupted our data, and since
     // mEncodeState.mAllowPartialData is true nothing will clean up for us here.
     auto * attributeDataWriter = mAttributeReportIBsBuilder.GetAttributeReport().GetAttributeData().GetWriter();
-    VerifyOrDie(attributeDataWriter->UnreserveBuffer(kEndOfListByteCount + kEndOfAttributeReportIBByteCount) == CHIP_NO_ERROR);
-    VerifyOrDie(attributeDataWriter->EndContainer(kAttributeDataIBType) == CHIP_NO_ERROR);
+    SuccessOrDie(attributeDataWriter->UnreserveBuffer(kEndOfListByteCount + kEndOfAttributeReportIBByteCount));
+    SuccessOrDie(attributeDataWriter->EndContainer(kAttributeDataIBType));
 
     AttributeReportBuilder builder;
-    VerifyOrDie(builder.FinishAttribute(mAttributeReportIBsBuilder) == CHIP_NO_ERROR);
+    SuccessOrDie(builder.FinishAttribute(mAttributeReportIBsBuilder));
 
     if (!mEncodedAtLeastOneListItem)
     {

src/app/BufferedReadCallback.cpp

@@ -94,7 +94,7 @@ CHIP_ERROR BufferedReadCallback::GenerateListTLV(TLV::ScopedBufferTLVReader & aR
 
     ReturnErrorOnFailure(writer.EndContainer(outerType));
 
-    writer.Finalize(backingBuffer);
+    TEMPORARY_RETURN_IGNORED writer.Finalize(backingBuffer);
 
     aReader.Init(std::move(backingBuffer), totalBufSize);
 

src/app/ClusterStateCache.cpp

@@ -426,7 +426,7 @@ void ClusterStateCacheT<CanEnableDataCaching>::OnAttributeData(const ConcreteDat
         dataSnapshot.Init(*apData);
     }
 
-    UpdateCache(aPath, apData, aStatus);
+    TEMPORARY_RETURN_IGNORED UpdateCache(aPath, apData, aStatus);
 
     //
     // Forward the call through.
@@ -458,7 +458,7 @@ void ClusterStateCacheT<CanEnableDataCaching>::OnEventData(const EventHeader & a
         dataSnapshot.Init(*apData);
     }
 
-    UpdateEventCache(aEventHeader, apData, apStatus);
+    TEMPORARY_RETURN_IGNORED UpdateEventCache(aEventHeader, apData, apStatus);
     mCallback.OnEventData(aEventHeader, apData ? &dataSnapshot : nullptr, apStatus);
 }
 

src/app/CommandHandlerImpl.cpp

@@ -260,7 +260,7 @@ Status CommandHandlerImpl::ProcessInvokeRequest(System::PacketBufferHandle && pa
     reader.Init(std::move(payload));
     VerifyOrReturnError(invokeRequestMessage.Init(reader) == CHIP_NO_ERROR, Status::InvalidAction);
 #if CHIP_CONFIG_IM_PRETTY_PRINT
-    invokeRequestMessage.PrettyPrint();
+    TEMPORARY_RETURN_IGNORED invokeRequestMessage.PrettyPrint();
 #endif
     VerifyOrDie(mpResponder);
     if (mpResponder->GetGroupId().HasValue())
@@ -980,7 +980,7 @@ void CommandHandlerImpl::TestOnlyInvokeCommandRequestWithFaultsInjected(CommandH
     VerifyOrDieWithMsg(invokeRequestMessage.Init(reader) == CHIP_NO_ERROR, DataManagement,
                        "TH Failure: Failed 'invokeRequestMessage.Init(reader)'");
 #if CHIP_CONFIG_IM_PRETTY_PRINT
-    invokeRequestMessage.PrettyPrint();
+    TEMPORARY_RETURN_IGNORED invokeRequestMessage.PrettyPrint();
 #endif
 
     VerifyOrDieWithMsg(invokeRequestMessage.GetSuppressResponse(&mSuppressResponse) == CHIP_NO_ERROR, DataManagement,

src/app/CommandHandlerImpl.h

@@ -325,7 +325,7 @@ class CommandHandlerImpl : public CommandHandler
             // The return value of RollbackResponse is ignored, as we prioritize
             // conveying the error generated by addResponseFunction to the
             // caller.
-            RollbackResponse();
+            TEMPORARY_RETURN_IGNORED RollbackResponse();
         }
         return err;
     }

src/app/CommandResponseSender.cpp

@@ -61,12 +61,12 @@ CHIP_ERROR CommandResponseSender::OnMessageReceived(Messaging::ExchangeContext *
         failureStatusToSend.SetValue(Status::Failure);
         ExitNow();
     }
-    StatusResponse::Send(Status::InvalidAction, mExchangeCtx.Get(), false /*aExpectResponse*/);
+    TEMPORARY_RETURN_IGNORED StatusResponse::Send(Status::InvalidAction, mExchangeCtx.Get(), false /*aExpectResponse*/);
     return err;
 exit:
     if (failureStatusToSend.HasValue())
     {
-        StatusResponse::Send(failureStatusToSend.Value(), mExchangeCtx.Get(), false /*aExpectResponse*/);
+        TEMPORARY_RETURN_IGNORED StatusResponse::Send(failureStatusToSend.Value(), mExchangeCtx.Get(), false /*aExpectResponse*/);
     }
     Close();
     return err;

src/app/CommandResponseSender.h

@@ -113,7 +113,7 @@ class CommandResponseSender : public Messaging::ExchangeDelegate,
         VerifyOrReturn(mExchangeCtx);
         auto * msgContext = mExchangeCtx->GetReliableMessageContext();
         VerifyOrReturn(msgContext != nullptr);
-        msgContext->FlushAcks();
+        TEMPORARY_RETURN_IGNORED msgContext->FlushAcks();
     }
 
     void AddInvokeResponseToSend(System::PacketBufferHandle && aPacket) override
@@ -173,7 +173,7 @@ class CommandResponseSender : public Messaging::ExchangeDelegate,
 
     void SendStatusResponse(Protocols::InteractionModel::Status aStatus)
     {
-        StatusResponse::Send(aStatus, mExchangeCtx.Get(), /*aExpectResponse = */ false);
+        TEMPORARY_RETURN_IGNORED StatusResponse::Send(aStatus, mExchangeCtx.Get(), /*aExpectResponse = */ false);
     }
 
     CHIP_ERROR SendCommandResponse();

src/app/CommandSender.cpp

@@ -250,7 +250,7 @@ CHIP_ERROR CommandSender::OnMessageReceived(Messaging::ExchangeContext * apExcha
         SuccessOrExit(err);
         if (moreChunkedMessages)
         {
-            StatusResponse::Send(Status::Success, apExchangeContext, /*aExpectResponse = */ true);
+            TEMPORARY_RETURN_IGNORED StatusResponse::Send(Status::Success, apExchangeContext, /*aExpectResponse = */ true);
             MoveToState(State::AwaitingResponse);
             return CHIP_NO_ERROR;
         }
@@ -276,7 +276,7 @@ CHIP_ERROR CommandSender::OnMessageReceived(Messaging::ExchangeContext * apExcha
 
     if (sendStatusResponse)
     {
-        StatusResponse::Send(Status::InvalidAction, apExchangeContext, /*aExpectResponse = */ false);
+        TEMPORARY_RETURN_IGNORED StatusResponse::Send(Status::InvalidAction, apExchangeContext, /*aExpectResponse = */ false);
     }
 
     if (mState != State::AwaitingResponse)
@@ -305,7 +305,7 @@ CHIP_ERROR CommandSender::ProcessInvokeResponse(System::PacketBufferHandle && pa
     ReturnErrorOnFailure(invokeResponseMessage.Init(reader));
 
 #if CHIP_CONFIG_IM_PRETTY_PRINT
-    invokeResponseMessage.PrettyPrint();
+    TEMPORARY_RETURN_IGNORED invokeResponseMessage.PrettyPrint();
 #endif
 
     ReturnErrorOnFailure(invokeResponseMessage.GetSuppressResponse(&suppressResponse));
@@ -403,7 +403,7 @@ CHIP_ERROR CommandSender::ProcessInvokeResponseIB(InvokeResponseIB::Parser & aIn
             ReturnErrorOnFailure(commandPath.GetEndpointId(&endpointId));
 
             StatusIB::Parser status;
-            commandStatus.GetErrorStatus(&status);
+            TEMPORARY_RETURN_IGNORED commandStatus.GetErrorStatus(&status);
             ReturnErrorOnFailure(status.DecodeStatusIB(statusIB));
             ReturnErrorOnFailure(GetRef(commandStatus, commandRef, commandRefRequired));
         }
@@ -416,7 +416,7 @@ CHIP_ERROR CommandSender::ProcessInvokeResponseIB(InvokeResponseIB::Parser & aIn
             ReturnErrorOnFailure(commandPath.GetEndpointId(&endpointId));
             ReturnErrorOnFailure(commandPath.GetClusterId(&clusterId));
             ReturnErrorOnFailure(commandPath.GetCommandId(&commandId));
-            commandData.GetFields(&commandDataReader);
+            TEMPORARY_RETURN_IGNORED commandData.GetFields(&commandDataReader);
             ReturnErrorOnFailure(GetRef(commandData, commandRef, commandRefRequired));
             err             = CHIP_NO_ERROR;
             hasDataResponse = true;
@@ -605,7 +605,7 @@ CHIP_ERROR CommandSender::FinishCommandInternal(FinishCommandParameters & aFinis
 
     if (mpPendingResponseTracker && aFinishCommandParams.commandRef.HasValue())
     {
-        mpPendingResponseTracker->Add(aFinishCommandParams.commandRef.Value());
+        TEMPORARY_RETURN_IGNORED mpPendingResponseTracker->Add(aFinishCommandParams.commandRef.Value());
     }
 
     if (aFinishCommandParams.timedInvokeTimeoutMs.HasValue())

src/app/EventManagement.cpp

@@ -326,7 +326,8 @@ CHIP_ERROR EventManagement::ConstructEvent(EventLoadOutContext * apContext, Even
     // Revisit FabricRemovedCB function should the encoding of fabricIndex change in the future.
     if (apOptions->mFabricIndex != kUndefinedFabricIndex)
     {
-        apContext->mWriter.Put(TLV::ProfileTag(kEventManagementProfile, kFabricIndexTag), apOptions->mFabricIndex);
+        TEMPORARY_RETURN_IGNORED apContext->mWriter.Put(TLV::ProfileTag(kEventManagementProfile, kFabricIndexTag),
+                                                        apOptions->mFabricIndex);
     }
     ReturnErrorOnFailure(eventDataIBBuilder.EndOfEventDataIB());
     ReturnErrorOnFailure(eventReportBuilder.EndOfEventReportIB());
@@ -342,8 +343,9 @@ void EventManagement::CreateEventManagement(Messaging::ExchangeManager * apExcha
                                             System::Clock::Milliseconds64 aMonotonicStartupTime)
 {
 
-    sInstance.Init(apExchangeManager, aNumBuffers, apCircularEventBuffer, apLogStorageResources, apEventNumberCounter,
-                   aMonotonicStartupTime, &InteractionModelEngine::GetInstance()->GetReportingEngine());
+    TEMPORARY_RETURN_IGNORED sInstance.Init(apExchangeManager, aNumBuffers, apCircularEventBuffer, apLogStorageResources,
+                                            apEventNumberCounter, aMonotonicStartupTime,
+                                            &InteractionModelEngine::GetInstance()->GetReportingEngine());
 }
 
 /**
@@ -905,7 +907,7 @@ void CircularEventReader::Init(CircularEventBufferWrapper * apBufWrapper)
     if (apBufWrapper->mpCurrent == nullptr)
         return;
 
-    TLVReader::Init(*apBufWrapper, apBufWrapper->mpCurrent->DataLength());
+    TEMPORARY_RETURN_IGNORED TLVReader::Init(*apBufWrapper, apBufWrapper->mpCurrent->DataLength());
     mMaxLen = apBufWrapper->mpCurrent->DataLength();
     for (prev = apBufWrapper->mpCurrent->GetPreviousCircularEventBuffer(); prev != nullptr;
          prev = prev->GetPreviousCircularEventBuffer())
@@ -919,7 +921,7 @@ void CircularEventReader::Init(CircularEventBufferWrapper * apBufWrapper)
 CHIP_ERROR CircularEventBufferWrapper::GetNextBuffer(TLVReader & aReader, const uint8_t *& aBufStart, uint32_t & aBufLen)
 {
     CHIP_ERROR err = CHIP_NO_ERROR;
-    mpCurrent->GetNextBuffer(aReader, aBufStart, aBufLen);
+    TEMPORARY_RETURN_IGNORED mpCurrent->GetNextBuffer(aReader, aBufStart, aBufLen);
     SuccessOrExit(err);
 
     if ((aBufLen == 0) && (mpCurrent->GetPreviousCircularEventBuffer() != nullptr))

src/app/FailSafeContext.cpp

@@ -100,7 +100,7 @@ void FailSafeContext::ScheduleFailSafeCleanup(FabricIndex fabricIndex, bool addN
         ChipLogError(FailSafe, "Failed to post fail-safe timer expired: %" CHIP_ERROR_FORMAT, status.Format());
     }
 
-    PlatformMgr().ScheduleWork(HandleDisarmFailSafe, reinterpret_cast<intptr_t>(this));
+    TEMPORARY_RETURN_IGNORED PlatformMgr().ScheduleWork(HandleDisarmFailSafe, reinterpret_cast<intptr_t>(this));
 }
 
 CHIP_ERROR FailSafeContext::ArmFailSafe(FabricIndex accessingFabricIndex, System::Clock::Seconds16 expiryLengthSeconds)