Skip to content

[Bug] Fail to import onediff into ComfyUI #1146

Open
@xmicro

Description

@xmicro

Your current environment information

Traceback (most recent call last):
File "C:\Users\Jrwhe\Documents\comfy\ComfyUI\nodes.py", line 2024, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "C:\Users\Jrwhe\Documents\comfy\ComfyUI\custom_nodes\onediff_comfy_nodes_init
.py", line 2, in
from onediff.utils.import_utils import is_nexfort_available, is_oneflow_available
File "C:\Users\Jrwhe\Documents\onediff\src\onediff\utils\import_utils.py", line 26, in
oneflow_available = check_module_availability("oneflow")
File "C:\Users\Jrwhe\Documents\onediff\src\onediff\utils\import_utils.py", line 16, in check_module_availability
importlib.import_module(module_name)
File "C:\Users\Jrwhe\AppData\Local\Programs\Python\Python310\lib\importlib_init
.py", line 126, in import_module
return _bootstrap.gcd_import(name[level:], package, level)
File "C:\Users\Jrwhe\Documents\comfy\venv\lib\site-packages\oneflow_init
.py", line 21, in
raise RuntimeError("This package is a placeholder. Please install oneflow following the instructions in https://github.com/Oneflow-Inc/oneflow#install-oneflow")
RuntimeError: This package is a placeholder. Please install oneflow following the instructions in https://github.com/Oneflow-Inc/oneflow#install-oneflow

Cannot import C:\Users\Jrwhe\Documents\comfy\ComfyUI\custom_nodes\onediff_comfy_nodes module for custom nodes: This package is a placeholder. Please install oneflow following the instructions in https://github.com/Oneflow-Inc/oneflow#install-oneflow

🐛 Describe the bug

Traceback (most recent call last):
File "C:\Users\Jrwhe\Documents\comfy\ComfyUI\nodes.py", line 2024, in load_custom_node
module_spec.loader.exec_module(module)
File "", line 883, in exec_module
File "", line 241, in call_with_frames_removed
File "C:\Users\Jrwhe\Documents\comfy\ComfyUI\custom_nodes\onediff_comfy_nodes_init
.py", line 2, in
from onediff.utils.import_utils import is_nexfort_available, is_oneflow_available
File "C:\Users\Jrwhe\Documents\onediff\src\onediff\utils\import_utils.py", line 26, in
oneflow_available = check_module_availability("oneflow")
File "C:\Users\Jrwhe\Documents\onediff\src\onediff\utils\import_utils.py", line 16, in check_module_availability
importlib.import_module(module_name)
File "C:\Users\Jrwhe\AppData\Local\Programs\Python\Python310\lib\importlib_init
.py", line 126, in import_module
return _bootstrap.gcd_import(name[level:], package, level)
File "C:\Users\Jrwhe\Documents\comfy\venv\lib\site-packages\oneflow_init
.py", line 21, in
raise RuntimeError("This package is a placeholder. Please install oneflow following the instructions in https://github.com/Oneflow-Inc/oneflow#install-oneflow")
RuntimeError: This package is a placeholder. Please install oneflow following the instructions in https://github.com/Oneflow-Inc/oneflow#install-oneflow

Cannot import C:\Users\Jrwhe\Documents\comfy\ComfyUI\custom_nodes\onediff_comfy_nodes module for custom nodes: This package is a placeholder. Please install oneflow following the instructions in https://github.com/Oneflow-Inc/oneflow#install-oneflow

Import times for custom nodes:
0.0 seconds: C:\Users\Jrwhe\Documents\comfy\ComfyUI\custom_nodes\websocket_image_save.py
0.1 seconds (IMPORT FAILED): C:\Users\Jrwhe\Documents\comfy\ComfyUI\custom_nodes\onediff_comfy_nodes
0.6 seconds: C:\Users\Jrwhe\Documents\comfy\ComfyUI\custom_nodes\ComfyUI-Manager

Import fails for onediff no matter if I install comfy using comfy-cli or normal git, no matter if I install onediff using comfy-cli or normal git, and no matter if I use venv or not. In this example, I installed comfy using comfy-cli, then onediff using git, and yes I did install Oneflow, and used venv to ensure a fresh environment. I'm not sure why it says "this is a placeholder" when the app literally tells you either to use symbolic link or just copy the specified directory to custom_nodes, of which I did the latter. Regardless though of I do this or use comfy-cli, I get an importation error. And the speedup and other node within ComfyUI are red, with "install missing custom nodes" doing nothing either. I'm unsure how to proceed from here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Request-bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions