'Hide in menu' option in CMS shouldn't also hide forums from forum list

[mandrew]

Wondered why forums weren't showing and turned out that the function 'Forum' on ForumHolder was checking if 'ShowInMenus' => 1 which seemed weird to me.

What if I wanted to hide forums in the menu but show them in the forum list or vice versa? I think this decision shouldn't be made for you in the code, there should be an extra check box (probably in the settings area, next to the hide in menu option) to hide the forum from the forum list.

[tractorcow]

This is probably because Children is used to select children (which filters out menu-hidden items) where AllChildren should probably be used. It's a bit of a misnomer that Children assumes only menu-visible children, but that's the way it is. :)

[mandrew]

No it first filters by ForumCategory and then a Forum::get() on CategoryID, ParentID and ShowInMenus and then a filterByCallback returning only the forums you can view

[camfindlay]

@tractorcow , @mandrew is correct, in the Forum::forums() method it makes an explicit call via the ORM to Forum::get() and filters for 'ShowInMenus' => 1 in effect changing this setting in the CMS causes 2 things to happen, one of which (hiding the actual forum) may not be what the users actually wants (they might just want to hid from menu).