SecurityAdmin ignores summary_fields and searchable_fields on Group

[GuySartorelli]

There is no search filter in the Groups tab in SecurityAdmin despite having the GridFieldFilterHeader in the groups GridFieldConfig.
What's more, if you customise the summary_fields or searchable_fields for Group via an Extension, the SecurityAdmin doesn't respect it.

This seems to be caused by the below lines which override the display fields for GridFieldDataColumns.

silverstripe-admin/code/SecurityAdmin.php

Lines 143 to 145 in 7f7fc72

	$columns->setDisplayFields(array(
	'Breadcrumbs' => Group::singleton()->fieldLabel('Title')
	));

Commenting out those lines provides the search filter and allows customised summary_fields or searchable_fields to be reflected correctly.

It also points out a deeper issue - the GridFieldFilterHeader should probably not be affected by GridFieldDataColumns if searchable_fields has been provided.

[forsdahl]

I think the solution here would be to change GridFieldFilterHeader to not check for filterable columns unless the legacy functionality is used, i.e. change:

https://github.com/silverstripe/silverstripe-framework/blob/724a9007df1d0f5efcdca78ccb022c0959b7ad5b/src/Forms/GridField/GridFieldFilterHeader.php#L497-L506

to:

    public function getHTMLFragments($gridField)
    {
        $forTemplate = new ArrayData([]);

        if ($this->useLegacyFilterHeader) {
            if (!$this->canFilterAnyColumns($gridField)) {
                return null;
            }
            $fieldsList = $this->getLegacyFilterHeader($gridField);

[maxime-rainville]

Not sure, but fixing #1350 will probably fix this issue.

[GuySartorelli]

This is no longer a problem for CMS 5 - but it remains a bug for CMS 4.