ENH Disable sorting on queries where sort order doesn't matter

Sorting queries can be slow, especially on large datasets and especially if indexes aren't optimised. We should avoid sorting when the sort order doesn't matter.

Author: GuySartorelli

src/Form/MultiLinkField.php

@@ -138,7 +138,7 @@ private function loadFrom(DataObject $record): void
         }
 
         // Load ids from relation
-        $value = array_values($relation->getIDList() ?? []);
+        $value = $relation->sort(null)->column('ID');
         parent::setValue($value);
     }
 

src/Tasks/MigrationTaskTrait.php

@@ -388,7 +388,7 @@ private function checkForBrokenLinks(): void
             foreach ($checkForBrokenLinks as $class => $data) {
                 $field = $data['field'];
                 $emptyValue = $data['emptyValue'];
-                $ids = DataObject::get($class)->filter([$field => $emptyValue])->column('ID');
+                $ids = DataObject::get($class)->filter([$field => $emptyValue])->sort(null)->column('ID');
                 $numBroken = count($ids);
                 $this->output->writeln("Found $numBroken broken links for the '$class' class.");
                 if ($numBroken > 0) {