Commit e56f51c
committed
MNT Fix link test to not pre-cache link owner before test starts.
With the new caching, this will fail tests that add versioned to the
class. That's because of a combination of factors:
- extension instances are stored on instances instead of accessed
statically
- in `DataObject::get_one()`, the `getUniqueKeyComponents()` method is
used to determine the cache key, which just _happens_ to be called on
a singleton, and we just _happen_ to have not generated a singleton of
the class until now, which means it has the versioned extension freshly
added to it.
This would be extremely unlikely to occur in real code, and I think our
response to a bug report would be "reset your cache after applying the
extension, or just don't fiddle around with extensions at runtime except
inside `_config.php`".1 parent 6251fdc commit e56f51c
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| 54 | + | |
| 55 | + | |
53 | 56 | | |
54 | 57 | | |
55 | 58 | | |
| |||
0 commit comments