ENH Hide PHP font icons from screen readers (#205)

Author: GuySartorelli

src/Forms/GridFieldSiteTreeAddNewButton.php

@@ -110,8 +110,8 @@ public function getHTMLFragments($gridField)
 
         $addAction = GridField_FormAction::create($gridField, 'add', $this->buttonName, 'add', 'add');
         $addAction
-            ->setAttribute('data-icon', 'add')
-            ->addExtraClass('no-ajax btn btn-primary font-icon-plus');
+            ->setIcon('add')
+            ->addExtraClass('no-ajax btn btn-primary');
 
         $forTemplate = ArrayData::create();
         $forTemplate->Fields = ArrayList::create();

src/Forms/GridFieldSiteTreeState.php

@@ -47,7 +47,7 @@ public function getColumnContent($gridField, $record, $columnName)
 
                 $published = $record->isPublished();
                 if (!$published) {
-                    return '<i class="font-icon-pencil btn--icon-md"></i>' .  _t(
+                    return '<span class="font-icon-pencil btn--icon-md" aria-hidden="true"></span>' .  _t(
                         __CLASS__ . '.Draft',
                         'Saved as Draft on {date}',
                         'State for when a post is saved.',
@@ -56,7 +56,7 @@ public function getColumnContent($gridField, $record, $columnName)
                         )
                     );
                 }
-                return '<i class="font-icon-check-mark-circle btn--icon-md"></i>' . _t(
+                return '<span class="font-icon-check-mark-circle btn--icon-md" aria-hidden="true"></span>' . _t(
                     __CLASS__ . '.Published',
                     'Published on {date}',
                     'State for when a post is published.',