ENH Use new DataList caching (#610)

Replaces deprecated `DataObject::get_one()` and `DataObject::get_by_id()` in favour of the new DataList query caching.

Author: GuySartorelli

src/Extension/AccountReset/MemberExtension.php

@@ -48,9 +48,7 @@ public function generateAccountResetTokenAndStoreHash(): string
             $token = $generator->randomToken();
             $hash = $this->owner->encryptWithUserSettings($token);
         } while (
-            DataObject::get_one(Member::class, [
-            '"Member"."AccountResetHash"' => $hash,
-            ])
+            Member::get()->setUseCache(true)->find('AccountResetHash', $hash)
         );
 
         $this->owner->AccountResetHash = $hash;

src/FormField/RegisteredMFAMethodListField.php

@@ -46,7 +46,7 @@ public function getSchemaDataDefaults()
         if (!$this->value && $this->getForm() && $this->getForm()->getRecord() instanceof Member) {
             $member = $this->getForm()->getRecord();
         } else {
-            $member = DataObject::get_by_id(Member::class, $this->value);
+            $member = Member::get()->setUseCache(true)->byID($this->value);
         }
 
         return array_merge($defaults, [

src/Store/SessionStore.php

@@ -71,7 +71,7 @@ public function __construct(Member $member)
     public function getMember(): ?Member
     {
         if (!$this->member && $this->memberID) {
-            $this->member = DataObject::get_by_id(Member::class, $this->memberID);
+            $this->member = Member::get()->setUseCache(true)->byID($this->memberID);
         }
 
         return $this->member;

tests/php/BackupCode/VerifyHandlerTest.php

@@ -44,7 +44,7 @@ public function testVerifyInvalidatesCodesThatHaveBeenUsed()
         list ($request, $store, $method) = $this->scaffoldVerifyParams('123456');
         $this->assertTrue($handler->verify($request, $store, $method)->isSuccessful());
 
-        $method = DataObject::get_by_id(RegisteredMethod::class, $method->ID);
+        $method = RegisteredMethod::get()->setUseCache(true)->byID($method->ID);
         $codes = json_decode($method->Data ?? '', true);
 
         $this->assertCount(3, $codes, 'Only 3 codes remain against the method');

tests/php/Service/RegisteredMethodManagerTest.php

@@ -184,8 +184,8 @@ public function testDeletingLastMethodRemovesBackupCodes()
 
         $this->assertCount(0, $member->RegisteredMFAMethods());
 
-        $this->assertNull(DataObject::get_by_id(RegisteredMethod::class, $backupMethod->ID));
-        $this->assertNull(DataObject::get_by_id(RegisteredMethod::class, $mathMethod->ID));
+        $this->assertNull(RegisteredMethod::get()->setUseCache(true)->byID($backupMethod->ID));
+        $this->assertNull(RegisteredMethod::get()->setUseCache(true)->byID($mathMethod->ID));
     }
 
     public function testCanRemoveTheOnlyMethodWhenMFAIsOptional()