API Deprecate API which was removed or changed in CMS 6 (#599)

Author: GuySartorelli

src/Controller/AdminRegistrationController.php

@@ -32,6 +32,9 @@ class AdminRegistrationController extends LeftAndMain
 
     private static $url_segment = 'mfa';
 
+    /**
+     * @deprecated 5.4.0 Will be removed without equivalent functionality to replace it
+     */
     private static $ignore_menuitem = true;
 
     private static $url_handlers = [

src/Extension/MemberExtension.php

@@ -5,6 +5,7 @@
 namespace SilverStripe\MFA\Extension;
 
 use SilverStripe\Control\Controller;
+use SilverStripe\Dev\Deprecation;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\MFA\Authenticator\ChangePasswordHandler;
 use SilverStripe\MFA\Exception\InvalidMethodException;
@@ -171,9 +172,11 @@ public function providePermissions(): array
 
     /**
      * Clear any temporary multi-factor authentication related session keys when a member is successfully logged in.
+     * @deprecated 5.4.0 Will be renamed to onAfterMemberLoggedIn()
      */
     public function afterMemberLoggedIn(): void
     {
+        Deprecation::noticeWithNoReplacment('5.4.0', 'Will be renamed to onAfterMemberLoggedIn()');
         if (!Controller::has_curr()) {
             return;
         }

src/Extension/RequirementsExtension.php

@@ -4,6 +4,7 @@
 
 use SilverStripe\Admin\LeftAndMain;
 use SilverStripe\Core\Extension;
+use SilverStripe\Dev\Deprecation;
 use SilverStripe\MFA\RequestHandler\BaseHandlerTrait;
 
 /**
@@ -15,9 +16,11 @@ class RequirementsExtension extends Extension
 
     /**
      * @see LeftAndMain::init()
+     * @deprecated 5.4.0 Will be renamed to onInit()
      */
     public function init()
     {
+        Deprecation::noticeWithNoReplacment('5.4.0', 'Will be renamed to onInit()');
         // As requirements for this module are dynamic - plugin methods apply their own requirements - we need to
         // include these requirements at run-time (opposed to using $extra_requirements_*)
         $this->applyRequirements(false);