Skip to content

Commit cdc0cf1

Browse files
authored
Merge pull request #6 from sminnee/ss4-support
SS4 support with segment-field 2.0
2 parents 0b14453 + 4d9c012 commit cdc0cf1

9 files changed

Lines changed: 44 additions & 24 deletions

File tree

.travis.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
language: php
22

33
php:
4-
- 5.3
5-
- 5.4
64
- 5.5
75
- 5.6
86
- 7.0
97

108
env:
11-
- DB=MYSQL CORE_RELEASE=3.1
9+
- DB=MYSQL CORE_RELEASE=master
1210

1311
before_script:
1412
- git clone git://github.com/silverstripe-labs/silverstripe-travis-support.git ~/travis-support

code/Filter/SlugFilter.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
namespace SilverStripe\Forms\Filter;
44

55
use SilverStripe\Forms\Filter;
6-
use URLSegmentFilter;
6+
7+
use SilverStripe\View\Parsers\URLSegmentFilter;
8+
79

810
class SlugFilter extends URLSegmentFilter implements Filter {
911
/**

code/SegmentField.php

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,11 @@
22

33
namespace SilverStripe\Forms;
44

5-
use Requirements;
6-
use TextField;
5+
6+
7+
use SilverStripe\View\Requirements;
8+
use SilverStripe\Forms\TextField;
9+
710

811
class SegmentField extends TextField {
912
/**
@@ -72,7 +75,7 @@ public function Preview() {
7275
* @return string
7376
*/
7477
public function Field($properties = array()) {
75-
Requirements::javascript(THIRDPARTY_DIR . '/jquery/jquery.js');
78+
Requirements::javascript('http://code.jquery.com/jquery-1.7.2.min.js');
7679
Requirements::javascript(SEGMENT_FIELD_DIR . '/public/segment-field.dist.js');
7780
Requirements::css(SEGMENT_FIELD_DIR . '/public/segment-field.css');
7881

code/SegmentFieldModifier/IDSegmentFieldModifier.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22

33
namespace SilverStripe\Forms\SegmentFieldModifier;
44

5-
use Form;
5+
6+
use SilverStripe\Forms\Form;
7+
68

79
class IDSegmentFieldModifier extends AbstractSegmentFieldModifier {
810
/**

code/SegmentFieldModifier/SlugSegmentFieldModifier.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
namespace SilverStripe\Forms\SegmentFieldModifier;
44

55
use SilverStripe\Forms\Filter\SlugFilter;
6-
use SS_HTTPRequest;
6+
7+
use SilverStripe\Control\HTTPRequest;
8+
79

810
class SlugSegmentFieldModifier extends AbstractSegmentFieldModifier {
911
/**
@@ -52,7 +54,7 @@ public function getSuggestion($value) {
5254
* @return string
5355
*/
5456
protected function getValue() {
55-
if($this->request instanceof SS_HTTPRequest && $value = $this->request->getVar('value')) {
57+
if($this->request instanceof HTTPRequest && $value = $this->request->getVar('value')) {
5658
return $value;
5759
}
5860

composer.json

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,19 @@
55
"keywords": ["silverstripe", "segment"],
66
"license": "MIT",
77
"require": {
8-
"silverstripe/framework": "^3.1",
9-
"silverstripe/cms": "^3.1"
8+
"silverstripe/framework": "^4.0@dev",
9+
"silverstripe/cms": "^4.0@dev"
1010
},
1111
"require-dev": {
1212
"phpunit/phpunit": "^3.7",
13-
"mockery/mockery": "^0.9"
13+
"mockery/mockery": "^0.9",
14+
"silverstripe/reports": "^4.0@dev",
15+
"silverstripe/siteconfig": "^4.0@dev"
16+
},
17+
"extra": {
18+
"branch-alias": {
19+
"dev-master": "2.0.x-dev"
20+
}
1421
},
1522
"autoload": {
1623
"psr-4": {

tests/SegmentFieldModifier/IDSegmentFieldModifierTest.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@
22

33
namespace SilverStripe\Forms\Tests;
44

5-
use Form;
5+
66
use Mockery;
7-
use SapphireTest;
7+
88
use SilverStripe\Forms\SegmentFieldModifier\IDSegmentFieldModifier;
99
use stdClass;
10+
use SilverStripe\Dev\SapphireTest;
11+
1012

1113
/**
1214
* @cover IDSegmentFieldModifier
@@ -42,7 +44,7 @@ protected function getNewFormMock() {
4244
$record = new StdClass();
4345
$record->ID = 123;
4446

45-
$mock = Mockery::mock('Form');
47+
$mock = Mockery::mock('SilverStripe\\Forms\\Form');
4648
$mock->shouldReceive('getRecord')->andReturn($record);
4749

4850
return $mock;

tests/SegmentFieldModifier/SlugSegmentFieldModifierTest.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,12 @@
22

33
namespace SilverStripe\Forms\Tests;
44

5-
use Form;
5+
66
use Mockery;
7-
use SapphireTest;
7+
88
use SilverStripe\Forms\SegmentFieldModifier\SlugSegmentFieldModifier;
9+
use SilverStripe\Dev\SapphireTest;
10+
911

1012
/**
1113
* @cover SlugSegmentFieldModifier
@@ -41,7 +43,7 @@ public function testGetPreview() {
4143
* @return Form
4244
*/
4345
protected function getNewRequestMock() {
44-
$mock = Mockery::mock('SS_HTTPRequest');
46+
$mock = Mockery::mock('SilverStripe\\Control\\HTTPRequest');
4547
$mock->shouldReceive('getVar')->with('value')->andReturn('This is a LONG value!');
4648

4749
return $mock;

tests/SegmentFieldTest.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,14 @@
22

33
namespace SilverStripe\Forms\Tests;
44

5-
use Form;
5+
66
use Mockery;
7-
use SapphireTest;
7+
88
use SilverStripe\Forms\SegmentField;
99
use SilverStripe\Forms\SegmentFieldModifier\AbstractSegmentFieldModifier;
10-
use SS_HTTPRequest;
10+
11+
use SilverStripe\Dev\SapphireTest;
12+
1113

1214
/**
1315
* @cover SegmentField
@@ -74,14 +76,14 @@ public function testGettersAndSetters()
7476
* @return SS_HTTPRequest
7577
*/
7678
protected function getNewRequestMock() {
77-
return Mockery::mock('SS_HTTPRequest');
79+
return Mockery::mock('SilverStripe\\Control\\HTTPRequest');
7880
}
7981

8082
/**
8183
* @return Form
8284
*/
8385
protected function getNewFormMock() {
84-
return Mockery::mock('Form');
86+
return Mockery::mock('SilverStripe\\Forms\\Form');
8587
}
8688
}
8789

0 commit comments

Comments
 (0)