Issuer returns a 500 error when Sitename contains a colon

[pjayme]

When a : is included as part of the Sitename in /admin/settings then we get a 500 error from the totp request with the Issuer class stating the error AssertInvalidArgumentException: Issuer must not contain a colon.

At a minimum, the docs should state that this should be avoided or if possible, the module should handle this scenario more gracefully.

[GuySartorelli]

I'm on the fence as to whether the module should handle those cases by stripping out the colons, or if we should just document it in the readme. I'll mark as an enhancement for now.

[michalkleiner]

Where is the name used or why does it matter?

[GuySartorelli]

The SiteConfig's Sitename is used as the "issuer", which is the name displayed in the authenticator app to identify the site. If it has a colon in it, the server error described occurs.