Skip to content

ChangeSet::removeObject() should handle case of implicit added item being removed. #415

@sabina-talipova

Description

@sabina-talipova

Description

Changesets can have items added implicitly. In that scenario, there may be no ChangeSetItem record in the database, so the current implementatio of removeObject() won't remove that implicit changeset item.

We should add logic to this method to check for implicit changeset items, and mark them as removed so they're not included in the actionable changeset.

See

if ($item) {
// TODO: Handle case of implicit added item being removed.
$item->delete();
}

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions