fix: parsing not working on fastify-plugin

Author: simenandre

src/__tests__/common.test.ts

@@ -75,17 +75,34 @@ describe('common', () => {
       message,
       handler,
       parser: data => parser(data),
-      context: { hello: 'there' },
       log: {} as pino.Logger,
     });
 
     expect(handler).toHaveBeenCalledWith({
       message,
       data: '',
-      context: { hello: 'there' },
       log: {} as pino.Logger,
     });
 
     expect(parser).toHaveBeenCalledWith({});
   });
+
+  it('should throw when parser fails', async () => {
+    const message = createPubSubdata({}, true);
+    const handler = jest.fn();
+    const parser = jest.fn(_ => {
+      throw new Error('error');
+    });
+
+    const result = () => {
+      return handlePubSubMessage({
+        message,
+        handler,
+        parser: data => parser(data),
+        log: {} as pino.Logger,
+      });
+    };
+
+    expect(result).rejects.toThrowErrorMatchingInlineSnapshot(`"error"`);
+  });
 });

src/__tests__/fastify-plugin.test.ts

@@ -1,5 +1,6 @@
 import Fastify, { FastifyInstance } from 'fastify';
 import { pubSubFastifyPlugin } from '../methods/fastify-plugin';
+import { PubSubConfig } from '../types';
 import { createPubSubRequest } from './fixtures';
 
 describe('fastify-plugin', () => {
@@ -94,6 +95,31 @@ describe('fastify-plugin', () => {
     );
   });
 
+  it('should throw when parsing fails', async () => {
+    const handler = jest.fn(() => ({ hello: 'world' }));
+    const parser = jest.fn(() => {
+      throw new Error('parsing fail');
+    });
+    const payload = createPubSubRequest('forward me');
+
+    app.register(pubSubFastifyPlugin, { handler, parser } as PubSubConfig<
+      any,
+      any
+    >);
+
+    const res = await app.inject({
+      method: 'POST',
+      url: '/',
+      payload,
+    });
+
+    expect(parser).toHaveBeenCalled();
+
+    expect(res.payload).toMatchInlineSnapshot(
+      `"{\\"statusCode\\":500,\\"error\\":\\"Internal Server Error\\",\\"message\\":\\"parsing fail\\"}"`,
+    );
+  });
+
   it('should not throw if request is missing attributes', async () => {
     const handler = jest.fn();
     const payload = {

src/methods/fastify-plugin.ts

@@ -7,7 +7,7 @@ const pubSubFastifyPluginFn = async <Data, Context>(
   fastify: FastifyInstance,
   options: PubSubConfig<Data, Context>,
 ): Promise<void> => {
-  const { path = '/', handler, parseJson, onError } = options;
+  const { path = '/', handler, parseJson, onError, parser } = options;
   fastify.post<{
     Body: PubSubRequestType;
   }>(
@@ -20,22 +20,22 @@ const pubSubFastifyPluginFn = async <Data, Context>(
     },
     async (req, reply) => {
       try {
-        const res = await handlePubSubMessage({
+        const res = await handlePubSubMessage<Data, Context>({
+          parser,
           message: req.body.message,
           handler,
           parseJson,
           // context: req,
           log: req.log,
         });
 
-        reply.code(res?.statusCode || 204);
+        return reply.code(res?.statusCode || 204).send();
       } catch (error) {
         if (onError) {
           await onError(error);
-          reply.code(204);
+          return reply.code(204).send();
         } else throw error;
       }
-      reply.send();
     },
   );
 };

src/types.ts

@@ -63,7 +63,7 @@ export interface HandlePubSubMessageArgs<Data, Context> {
   message: PubSubMessageType;
   handler: PubSubHandler<Data, Context>;
   parseJson?: boolean;
-  parser?: (data: unknown) => Data;
+  parser?: (data: unknown) => Data | Promise<Data>;
   context?: Context;
   log?: pino.Logger | FastifyBaseLogger;
 }