Skip to content

Commit b3f1505

Browse files
authored
Fix examples running on LAN (#290)
- We should bind "0.0.0.0" for UdpSocket. - ` public_addresses` is not needed with `ServerAuthentication::Unsecure`.
1 parent 434837b commit b3f1505

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

bevy_replicon_renet/examples/simple_box.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,14 +89,13 @@ impl SimpleBoxPlugin {
8989
});
9090

9191
let current_time = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)?;
92-
let public_addr = SocketAddr::new(Ipv4Addr::LOCALHOST.into(), port);
93-
let socket = UdpSocket::bind(public_addr)?;
92+
let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, port))?;
9493
let server_config = ServerConfig {
9594
current_time,
9695
max_clients: 10,
9796
protocol_id: PROTOCOL_ID,
9897
authentication: ServerAuthentication::Unsecure,
99-
public_addresses: vec![public_addr],
98+
public_addresses: Default::default(),
10099
};
101100
let transport = NetcodeServerTransport::new(server_config, socket)?;
102101

@@ -130,7 +129,7 @@ impl SimpleBoxPlugin {
130129
let current_time = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)?;
131130
let client_id = current_time.as_millis() as u64;
132131
let server_addr = SocketAddr::new(ip, port);
133-
let socket = UdpSocket::bind((ip, 0))?;
132+
let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, 0))?;
134133
let authentication = ClientAuthentication::Unsecure {
135134
client_id,
136135
protocol_id: PROTOCOL_ID,

bevy_replicon_renet/examples/tic_tac_toe.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -262,14 +262,13 @@ impl TicTacToePlugin {
262262
});
263263

264264
let current_time = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)?;
265-
let public_addr = SocketAddr::new(Ipv4Addr::LOCALHOST.into(), port);
266-
let socket = UdpSocket::bind(public_addr)?;
265+
let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, port))?;
267266
let server_config = ServerConfig {
268267
current_time,
269268
max_clients: 1,
270269
protocol_id: PROTOCOL_ID,
271270
authentication: ServerAuthentication::Unsecure,
272-
public_addresses: vec![public_addr],
271+
public_addresses: Default::default(),
273272
};
274273
let transport = NetcodeServerTransport::new(server_config, socket)?;
275274

@@ -290,7 +289,7 @@ impl TicTacToePlugin {
290289
let current_time = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)?;
291290
let client_id = current_time.as_millis() as u64;
292291
let server_addr = SocketAddr::new(ip, port);
293-
let socket = UdpSocket::bind((ip, 0))?;
292+
let socket = UdpSocket::bind((Ipv4Addr::UNSPECIFIED, 0))?;
294293
let authentication = ClientAuthentication::Unsecure {
295294
client_id,
296295
protocol_id: PROTOCOL_ID,

0 commit comments

Comments
 (0)