refactor(integrations): rename gemini package to provider-neutral ai (closes #68) (#95)

Kavirubc · web-flow · commit fb6f9d472f66 · 2026-03-03T13:42:20.000+05:30
* feat(integrations): add provider-neutral ai package Introduces internal/integrations/ai as a renamed copy of the former gemini package. Package declaration updated to `package ai` across all source and test files. Removes the TODO comment in embedder.go that flagged the misleading package name and updates the package-level doc comment accordingly. No behaviour changes — all logic, types, and tests are identical. Relates to #68 Signed-off-by: Kavirubc <hapuarachchikaviru@gmail.com> * refactor: migrate all callers from integrations/gemini to integrations/ai Updates every import path and package qualifier across all 16 caller files: internal/steps/ — 10 files (transfer_check, response_builder, duplicate_detector, similarity, vectordb_prep, indexer, llm_router, quality_checker, triage, response_builder_test) internal/transfer/ — vdb_router.go internal/core/pipeline/ — registry.go cmd/simili/commands/ — batch, index, learn, process cmd/simili-web/ — main.go `gemini.X` → `ai.X` at every call site. No logic changes. Relates to #68 Signed-off-by: Kavirubc <hapuarachchikaviru@gmail.com> * chore(integrations): remove deprecated gemini package Deletes internal/integrations/gemini now that all callers have been migrated to internal/integrations/ai. Keeps the codebase free of dead code and eliminates the misleading provider-specific package name. Closes #68 Signed-off-by: Kavirubc <hapuarachchikaviru@gmail.com> * fix(integrations): address review comments — stale names and docs - retry.go: update package-level doc from "Package gemini" to "Package ai" to match the declared package name - vdb_router.go: rename NewVDBRouterFromGemini → NewVDBRouterFromEmbedder and fix its stale doc comment - index.go: rename local variable geminiClient → embedder to match the provider-neutral *ai.Embedder type - gemini_test.go → prompts_test.go: rename test file to a provider-neutral name consistent with the package rename Relates to #68 Signed-off-by: Kavirubc <hapuarachchikaviru@gmail.com> * fix(integrations): delete gemini_test.go after rename to prompts_test.go The previous commit added prompts_test.go but did not stage the deletion of gemini_test.go, leaving both files tracked by git and causing duplicate function declaration errors in CI. Relates to #68 Signed-off-by: Kavirubc <hapuarachchikaviru@gmail.com> --------- Signed-off-by: Kavirubc <hapuarachchikaviru@gmail.com>
diff --git a/cmd/simili-web/main.go b/cmd/simili-web/main.go
@@ -17,7 +17,7 @@ import (
 
 	"github.com/similigh/simili-bot/internal/core/config"
 	"github.com/similigh/simili-bot/internal/core/pipeline"
-	"github.com/similigh/simili-bot/internal/integrations/gemini"
+	"github.com/similigh/simili-bot/internal/integrations/ai"
 	"github.com/similigh/simili-bot/internal/integrations/github"
 	"github.com/similigh/simili-bot/internal/integrations/qdrant"
 	"github.com/similigh/simili-bot/internal/steps"
@@ -115,7 +115,7 @@ func initDependencies(cfg *config.Config) (*pipeline.Dependencies, error) {
 	}
 
 	// Embedder (Gemini/OpenAI auto-selected by available keys)
-	embedder, err := gemini.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)
+	embedder, err := ai.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)
 	if err != nil {
 		return nil, fmt.Errorf("failed to init embedder: %w", err)
 	}
@@ -151,7 +151,7 @@ func initDependencies(cfg *config.Config) (*pipeline.Dependencies, error) {
 	if envModel := os.Getenv("LLM_MODEL"); envModel != "" {
 		llmModel = envModel
 	}
-	llm, err := gemini.NewLLMClient(llmKey, llmModel)
+	llm, err := ai.NewLLMClient(llmKey, llmModel)
 	if err != nil {
 		return nil, fmt.Errorf("failed to init LLM: %w", err)
 	}
diff --git a/cmd/simili/commands/batch.go b/cmd/simili/commands/batch.go
@@ -21,7 +21,7 @@ import (
 
 	"github.com/similigh/simili-bot/internal/core/config"
 	"github.com/similigh/simili-bot/internal/core/pipeline"
-	"github.com/similigh/simili-bot/internal/integrations/gemini"
+	"github.com/similigh/simili-bot/internal/integrations/ai"
 	"github.com/similigh/simili-bot/internal/integrations/github"
 	"github.com/similigh/simili-bot/internal/integrations/qdrant"
 )
@@ -281,7 +281,7 @@ func initializeDependencies(cfg *config.Config) (*pipeline.Dependencies, error)
 	deps := &pipeline.Dependencies{}
 
 	// Initialize Embedder (Gemini/OpenAI auto-selected by available keys)
-	embedder, err := gemini.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)
+	embedder, err := ai.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)
 	if err != nil {
 		return nil, fmt.Errorf("failed to initialize embedder: %w", err)
 	}
@@ -338,7 +338,7 @@ func initializeDependencies(cfg *config.Config) (*pipeline.Dependencies, error)
 	if envModel := os.Getenv("LLM_MODEL"); envModel != "" {
 		llmModel = envModel
 	}
-	llm, err := gemini.NewLLMClient(llmKey, llmModel)
+	llm, err := ai.NewLLMClient(llmKey, llmModel)
 	if err != nil {
 		return nil, fmt.Errorf("failed to initialize LLM client: %w", err)
 	}
diff --git a/cmd/simili/commands/index.go b/cmd/simili/commands/index.go
@@ -17,7 +17,7 @@ import (
 	"github.com/google/go-github/v60/github"
 	"github.com/google/uuid"
 	similiConfig "github.com/similigh/simili-bot/internal/core/config"
-	"github.com/similigh/simili-bot/internal/integrations/gemini"
+	"github.com/similigh/simili-bot/internal/integrations/ai"
 	similiGithub "github.com/similigh/simili-bot/internal/integrations/github"
 	"github.com/similigh/simili-bot/internal/integrations/qdrant"
 	"github.com/similigh/simili-bot/internal/utils/text"
@@ -89,13 +89,13 @@ func runIndex(cmd *cobra.Command, args []string) {
 
 	ghClient := similiGithub.NewClient(ctx, token)
 
-	geminiClient, err := gemini.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)
+	embedder, err := ai.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)
 	if err != nil {
 		log.Fatalf("Failed to init embedder: %v", err)
 	}
-	defer geminiClient.Close()
+	defer embedder.Close()
 	embeddingDimensions := cfg.Embedding.Dimensions
-	if dim := geminiClient.Dimensions(); dim > 0 {
+	if dim := embedder.Dimensions(); dim > 0 {
 		embeddingDimensions = dim
 	}
 
@@ -144,7 +144,7 @@ func runIndex(cmd *cobra.Command, args []string) {
 		go func(id int) {
 			defer wg.Done()
 			for job := range jobs {
-				processIssue(ctx, id, job.Issue, ghClient, geminiClient, qdrantClient, splitter, cfg.Qdrant.Collection, org, repoName, indexDryRun)
+				processIssue(ctx, id, job.Issue, ghClient, embedder, qdrantClient, splitter, cfg.Qdrant.Collection, org, repoName, indexDryRun)
 			}
 		}(i)
 	}
@@ -198,7 +198,7 @@ func runIndex(cmd *cobra.Command, args []string) {
 	log.Println("Indexing complete.")
 }
 
-func processIssue(ctx context.Context, workerID int, issue *github.Issue, gh *similiGithub.Client, em *gemini.Embedder, qd *qdrant.Client, splitter *text.RecursiveCharacterSplitter, collection, org, repo string, dryRun bool) {
+func processIssue(ctx context.Context, workerID int, issue *github.Issue, gh *similiGithub.Client, em *ai.Embedder, qd *qdrant.Client, splitter *text.RecursiveCharacterSplitter, collection, org, repo string, dryRun bool) {
 	// 1. Fetch Comments (with pagination)
 	var allComments []*github.IssueComment
 	page := 1
diff --git a/cmd/simili/commands/learn.go b/cmd/simili/commands/learn.go
@@ -16,7 +16,7 @@ import (
 	"time"
 
 	similiConfig "github.com/similigh/simili-bot/internal/core/config"
-	"github.com/similigh/simili-bot/internal/integrations/gemini"
+	"github.com/similigh/simili-bot/internal/integrations/ai"
 	similiGithub "github.com/similigh/simili-bot/internal/integrations/github"
 	"github.com/similigh/simili-bot/internal/integrations/qdrant"
 	"github.com/spf13/cobra"
@@ -89,7 +89,7 @@ func runLearn(cmd *cobra.Command, args []string) {
 	ghClient := similiGithub.NewClient(ctx, token)
 
 	// 3. Initialize Embedder
-	embedder, err := gemini.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)
+	embedder, err := ai.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)
 	if err != nil {
 		log.Fatalf("Failed to initialize embedder: %v", err)
 	}
diff --git a/cmd/simili/commands/process.go b/cmd/simili/commands/process.go
@@ -18,7 +18,7 @@ import (
 
 	"github.com/similigh/simili-bot/internal/core/config"
 	"github.com/similigh/simili-bot/internal/core/pipeline"
-	"github.com/similigh/simili-bot/internal/integrations/gemini"
+	"github.com/similigh/simili-bot/internal/integrations/ai"
 	"github.com/similigh/simili-bot/internal/integrations/github"
 	"github.com/similigh/simili-bot/internal/integrations/qdrant"
 )
@@ -204,7 +204,7 @@ func runProcess() {
 
 	// Initialize clients with error logging
 	// Embedder
-	embedder, err := gemini.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)
+	embedder, err := ai.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)
 	if err == nil {
 		deps.Embedder = embedder
 		if verbose {
@@ -262,7 +262,7 @@ func runProcess() {
 	if envModel := os.Getenv("LLM_MODEL"); envModel != "" {
 		llmModel = envModel
 	}
-	llm, err := gemini.NewLLMClient(llmKey, llmModel)
+	llm, err := ai.NewLLMClient(llmKey, llmModel)
 	if err == nil {
 		deps.LLMClient = llm
 		if verbose {
diff --git a/internal/core/pipeline/registry.go b/internal/core/pipeline/registry.go
@@ -10,7 +10,7 @@ import (
 	"fmt"
 	"sync"
 
-	"github.com/similigh/simili-bot/internal/integrations/gemini"
+	"github.com/similigh/simili-bot/internal/integrations/ai"
 	"github.com/similigh/simili-bot/internal/integrations/github"
 	"github.com/similigh/simili-bot/internal/integrations/qdrant"
 )
@@ -28,8 +28,8 @@ type StepFactory func(deps *Dependencies) (Step, error)
 
 // Dependencies holds the dependencies that can be injected into steps.
 type Dependencies struct {
-	Embedder    *gemini.Embedder
-	LLMClient   *gemini.LLMClient
+	Embedder    *ai.Embedder
+	LLMClient   *ai.LLMClient
 	VectorStore qdrant.VectorStore
 	GitHub      *github.Client
 	DryRun      bool
diff --git a/internal/integrations/ai/embedder.go b/internal/integrations/ai/embedder.go
@@ -3,12 +3,8 @@
 // Created: 2026-02-02
 // Last Modified: 2026-02-17
 
-// Package gemini provides AI integration for embeddings and LLM.
-//
-// TODO(2026-02-16): This package is named "gemini" for historical reasons, but it
-// now supports multiple providers (Gemini and OpenAI). Recommend renaming
-// directory/package to provider-neutral naming (for example `internal/integrations/ai`).
-package gemini
+// Package ai provides AI integration for embeddings and LLM.
+package ai
 
 import (
 	"context"
diff --git a/internal/integrations/ai/llm.go b/internal/integrations/ai/llm.go
@@ -3,7 +3,7 @@
 // Created: 2026-02-02
 // Last Modified: 2026-02-17
 
-package gemini
+package ai
 
 import (
 	"context"
diff --git a/internal/integrations/ai/prompts.go b/internal/integrations/ai/prompts.go
@@ -3,7 +3,7 @@
 // Created: 2026-02-02
 // Last Modified: 2026-02-05
 
-package gemini
+package ai
 
 import (
 	"fmt"
diff --git a/internal/integrations/ai/prompts_test.go b/internal/integrations/ai/prompts_test.go
@@ -3,7 +3,7 @@
 // Created: 2026-02-02
 // Last Modified: 2026-02-02
 
-package gemini
+package ai
 
 import (
 	"strings"
diff --git a/internal/integrations/ai/provider.go b/internal/integrations/ai/provider.go
@@ -1,4 +1,4 @@
-package gemini
+package ai
 
 import (
 	"bytes"
diff --git a/internal/integrations/ai/provider_test.go b/internal/integrations/ai/provider_test.go
@@ -1,4 +1,4 @@
-package gemini
+package ai
 
 import "testing"
 
diff --git a/internal/integrations/ai/retry.go b/internal/integrations/ai/retry.go
@@ -3,8 +3,8 @@
 // Created: 2026-02-15
 // Last Modified: 2026-02-17
 
-// Package gemini provides Gemini AI integration for embeddings and LLM.
-package gemini
+// Package ai provides provider-neutral AI integration for embeddings and LLM.
+package ai
 
 import (
 	"context"
diff --git a/internal/integrations/ai/retry_test.go b/internal/integrations/ai/retry_test.go
@@ -3,7 +3,7 @@
 // Created: 2026-02-15
 // Last Modified: 2026-02-17
 
-package gemini
+package ai
 
 import (
 	"context"
diff --git a/internal/steps/duplicate_detector.go b/internal/steps/duplicate_detector.go
@@ -9,12 +9,12 @@ import (
 	"log"
 
 	"github.com/similigh/simili-bot/internal/core/pipeline"
-	"github.com/similigh/simili-bot/internal/integrations/gemini"
+	"github.com/similigh/simili-bot/internal/integrations/ai"
 )
 
 // DuplicateDetector analyzes similarity results for duplicates using LLM.
 type DuplicateDetector struct {
-	llm *gemini.LLMClient
+	llm *ai.LLMClient
 }
 
 // NewDuplicateDetector creates a new duplicate detector step.
@@ -60,9 +60,9 @@ func (s *DuplicateDetector) Run(ctx *pipeline.Context) error {
 		maxSimilar = len(ctx.SimilarIssues)
 	}
 
-	similarInput := make([]gemini.SimilarIssueInput, maxSimilar)
+	similarInput := make([]ai.SimilarIssueInput, maxSimilar)
 	for i := 0; i < maxSimilar; i++ {
-		similarInput[i] = gemini.SimilarIssueInput{
+		similarInput[i] = ai.SimilarIssueInput{
 			Number:     ctx.SimilarIssues[i].Number,
 			Title:      ctx.SimilarIssues[i].Title,
 			Body:       ctx.SimilarIssues[i].Body,
@@ -72,8 +72,8 @@ func (s *DuplicateDetector) Run(ctx *pipeline.Context) error {
 		}
 	}
 
-	input := &gemini.DuplicateCheckInput{
-		CurrentIssue: &gemini.IssueInput{
+	input := &ai.DuplicateCheckInput{
+		CurrentIssue: &ai.IssueInput{
 			Title:  ctx.Issue.Title,
 			Body:   ctx.Issue.Body,
 			Author: ctx.Issue.Author,
diff --git a/internal/steps/indexer.go b/internal/steps/indexer.go
@@ -14,15 +14,15 @@ import (
 	"github.com/google/go-github/v60/github"
 	"github.com/google/uuid"
 	"github.com/similigh/simili-bot/internal/core/pipeline"
-	"github.com/similigh/simili-bot/internal/integrations/gemini"
+	"github.com/similigh/simili-bot/internal/integrations/ai"
 	similiGithub "github.com/similigh/simili-bot/internal/integrations/github"
 	"github.com/similigh/simili-bot/internal/integrations/qdrant"
 	"github.com/similigh/simili-bot/internal/utils/text"
 )
 
 // Indexer adds/updates the issue in the vector database.
 type Indexer struct {
-	embedder *gemini.Embedder
+	embedder *ai.Embedder
 	store    qdrant.VectorStore
 	github   *similiGithub.Client
 	dryRun   bool
diff --git a/internal/steps/llm_router.go b/internal/steps/llm_router.go
@@ -10,14 +10,14 @@ import (
 	"log"
 
 	"github.com/similigh/simili-bot/internal/core/pipeline"
-	"github.com/similigh/simili-bot/internal/integrations/gemini"
+	"github.com/similigh/simili-bot/internal/integrations/ai"
 	"github.com/similigh/simili-bot/internal/integrations/qdrant"
 )
 
 // LLMRouter analyzes issue intent and routes to best repository using LLM.
 type LLMRouter struct {
-	llm      *gemini.LLMClient
-	embedder *gemini.Embedder
+	llm      *ai.LLMClient
+	embedder *ai.Embedder
 	store    qdrant.VectorStore
 }
 
@@ -64,14 +64,14 @@ func (s *LLMRouter) Run(ctx *pipeline.Context) error {
 	log.Printf("[llm_router] Analyzing issue #%d for routing", ctx.Issue.Number)
 
 	// Collect repository candidates (include current repo to allow "stay here" decision)
-	var candidates []gemini.RepositoryCandidate
+	var candidates []ai.RepositoryCandidate
 	currentRepo := fmt.Sprintf("%s/%s", ctx.Issue.Org, ctx.Issue.Repo)
 
 	for _, repo := range ctx.Config.Repositories {
 		if !repo.Enabled || repo.Description == "" {
 			continue
 		}
-		candidates = append(candidates, gemini.RepositoryCandidate{
+		candidates = append(candidates, ai.RepositoryCandidate{
 			Org:         repo.Org,
 			Repo:        repo.Repo,
 			Description: repo.Description,
@@ -171,8 +171,8 @@ func (s *LLMRouter) Run(ctx *pipeline.Context) error {
 	}
 
 	// Call LLM to route issue (reuse currentRepo from above)
-	input := &gemini.RouteIssueInput{
-		Issue: &gemini.IssueInput{
+	input := &ai.RouteIssueInput{
+		Issue: &ai.IssueInput{
 			Title:  ctx.Issue.Title,
 			Body:   ctx.Issue.Body,
 			Author: ctx.Issue.Author,
diff --git a/internal/steps/quality_checker.go b/internal/steps/quality_checker.go
@@ -9,12 +9,12 @@ import (
 	"log"
 
 	"github.com/similigh/simili-bot/internal/core/pipeline"
-	"github.com/similigh/simili-bot/internal/integrations/gemini"
+	"github.com/similigh/simili-bot/internal/integrations/ai"
 )
 
 // QualityChecker assesses issue quality using LLM.
 type QualityChecker struct {
-	llm *gemini.LLMClient
+	llm *ai.LLMClient
 }
 
 // NewQualityChecker creates a new quality checker step.
@@ -42,7 +42,7 @@ func (s *QualityChecker) Run(ctx *pipeline.Context) error {
 
 	log.Printf("[quality_checker] Assessing quality for issue #%d", ctx.Issue.Number)
 
-	input := &gemini.IssueInput{
+	input := &ai.IssueInput{
 		Title:  ctx.Issue.Title,
 		Body:   ctx.Issue.Body,
 		Author: ctx.Issue.Author,
diff --git a/internal/steps/response_builder.go b/internal/steps/response_builder.go
diff --git a/internal/steps/response_builder_test.go b/internal/steps/response_builder_test.go
diff --git a/internal/steps/similarity.go b/internal/steps/similarity.go
diff --git a/internal/steps/transfer_check.go b/internal/steps/transfer_check.go
diff --git a/internal/steps/triage.go b/internal/steps/triage.go
diff --git a/internal/steps/vectordb_prep.go b/internal/steps/vectordb_prep.go
diff --git a/internal/transfer/vdb_router.go b/internal/transfer/vdb_router.go

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ import (`
`17`	`17`
`18`	`18`	`"github.com/similigh/simili-bot/internal/core/config"`
`19`	`19`	`"github.com/similigh/simili-bot/internal/core/pipeline"`
`20`		`- "github.com/similigh/simili-bot/internal/integrations/gemini"`
	`20`	`+ "github.com/similigh/simili-bot/internal/integrations/ai"`
`21`	`21`	`"github.com/similigh/simili-bot/internal/integrations/github"`
`22`	`22`	`"github.com/similigh/simili-bot/internal/integrations/qdrant"`
`23`	`23`	`"github.com/similigh/simili-bot/internal/steps"`
`@@ -115,7 +115,7 @@ func initDependencies(cfg config.Config) (pipeline.Dependencies, error) {`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`// Embedder (Gemini/OpenAI auto-selected by available keys)`
`118`		`- embedder, err := gemini.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)`
	`118`	`+ embedder, err := ai.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)`
`119`	`119`	`if err != nil {`
`120`	`120`	`return nil, fmt.Errorf("failed to init embedder: %w", err)`
`121`	`121`	`}`
`@@ -151,7 +151,7 @@ func initDependencies(cfg config.Config) (pipeline.Dependencies, error) {`
`151`	`151`	`if envModel := os.Getenv("LLM_MODEL"); envModel != "" {`
`152`	`152`	`llmModel = envModel`
`153`	`153`	`}`
`154`		`- llm, err := gemini.NewLLMClient(llmKey, llmModel)`
	`154`	`+ llm, err := ai.NewLLMClient(llmKey, llmModel)`
`155`	`155`	`if err != nil {`
`156`	`156`	`return nil, fmt.Errorf("failed to init LLM: %w", err)`
`157`	`157`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ import (`
`21`	`21`
`22`	`22`	`"github.com/similigh/simili-bot/internal/core/config"`
`23`	`23`	`"github.com/similigh/simili-bot/internal/core/pipeline"`
`24`		`- "github.com/similigh/simili-bot/internal/integrations/gemini"`
	`24`	`+ "github.com/similigh/simili-bot/internal/integrations/ai"`
`25`	`25`	`"github.com/similigh/simili-bot/internal/integrations/github"`
`26`	`26`	`"github.com/similigh/simili-bot/internal/integrations/qdrant"`
`27`	`27`	`)`
`@@ -281,7 +281,7 @@ func initializeDependencies(cfg config.Config) (pipeline.Dependencies, error)`
`281`	`281`	`deps := &pipeline.Dependencies{}`
`282`	`282`
`283`	`283`	`// Initialize Embedder (Gemini/OpenAI auto-selected by available keys)`
`284`		`- embedder, err := gemini.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)`
	`284`	`+ embedder, err := ai.NewEmbedder(cfg.Embedding.APIKey, cfg.Embedding.Model)`
`285`	`285`	`if err != nil {`
`286`	`286`	`return nil, fmt.Errorf("failed to initialize embedder: %w", err)`
`287`	`287`	`}`
`@@ -338,7 +338,7 @@ func initializeDependencies(cfg config.Config) (pipeline.Dependencies, error)`
`338`	`338`	`if envModel := os.Getenv("LLM_MODEL"); envModel != "" {`
`339`	`339`	`llmModel = envModel`
`340`	`340`	`}`
`341`		`- llm, err := gemini.NewLLMClient(llmKey, llmModel)`
	`341`	`+ llm, err := ai.NewLLMClient(llmKey, llmModel)`
`342`	`342`	`if err != nil {`
`343`	`343`	`return nil, fmt.Errorf("failed to initialize LLM client: %w", err)`
`344`	`344`	`}`