Update impls with CanDispel + bugfixes to Buffs/Debuffs (#335)

Update existing implementations with `CanDispel: true,` where needed, by checking modifiers that are Buffs or Debuffs
There are only a handful of currently known "Dispellable Other"-type modifiers on characters (i.e., Firefly, Jade, MarchHunt, ) and LCs (i.e., Earthly Escapade), all of which are unimplemented at this time

Additional notes:
* fix DHIL A4, Cornucopia (LC) to correctly be considered Other instead of Buff
* fix Bronya E2 Spd Buff with correct Stacking and Flag
* fix Bronya Skill Buff with correct Stacking
* fix Bronya A4 with correct Stacking
* fix Bronya Ult with correct Stacking
* fix Gepard Ult with correct Stacking
* fix Qingque Talent Atk Buff with correct Stacking
* fix Huohuo Ult Atk Buff with correct Stacking
* fix Silver Wolf E6 with correct StatusType/remove unnecessary fields
* fix Kafka E1 Debuff to correctly apply damage taken increase
* fix Mutual Demise (LC) with correct stacking
* Blade will be reworked in a separate PR
* Something Irreplacable (LC) will be reworked in a separate PR

Author: kdovtdc

internal/character/asta/ult.go

@@ -17,6 +17,7 @@ func init() {
 		Stacking:      modifier.ReplaceBySource,
 		StatusType:    model.StatusType_STATUS_BUFF,
 		BehaviorFlags: []model.BehaviorFlag{model.BehaviorFlag_STAT_SPEED_UP},
+		CanDispel:     true,
 		Duration:      2,
 	})
 }

internal/character/bronya/eidolon.go

@@ -32,8 +32,11 @@ func init() {
 	})
 
 	modifier.Register(E2Buff, modifier.Config{
-		StatusType: model.StatusType_STATUS_BUFF,
-		Duration:   1,
+		StatusType:    model.StatusType_STATUS_BUFF,
+		Stacking:      modifier.ReplaceBySource,
+		BehaviorFlags: []model.BehaviorFlag{model.BehaviorFlag_STAT_SPEED_UP},
+		CanDispel:     true,
+		Duration:      1,
 	})
 
 	modifier.Register(E4Cooldown, modifier.Config{

internal/character/bronya/skill.go

@@ -15,6 +15,8 @@ const (
 func init() {
 	modifier.Register(Skill, modifier.Config{
 		StatusType: model.StatusType_STATUS_BUFF,
+		Stacking:   modifier.ReplaceBySource,
+		CanDispel:  true,
 	})
 }
 

internal/character/bronya/technique.go

@@ -15,6 +15,7 @@ const (
 func init() {
 	modifier.Register(Technique, modifier.Config{
 		StatusType: model.StatusType_STATUS_BUFF,
+		CanDispel:  true,
 		Listeners: modifier.Listeners{
 			OnAdd: func(mod *modifier.Instance) {
 				mod.SetProperty(prop.ATKPercent, 0.15)

internal/character/bronya/trace.go

@@ -30,6 +30,8 @@ func init() {
 	// A4 Register
 	modifier.Register(A4, modifier.Config{
 		StatusType: model.StatusType_STATUS_BUFF,
+		Stacking:   modifier.ReplaceBySource,
+		CanDispel:  true,
 		Listeners: modifier.Listeners{
 			OnAdd: func(mod *modifier.Instance) {
 				mod.SetProperty(prop.DEFPercent, 0.2)

internal/character/bronya/ult.go

@@ -15,6 +15,8 @@ const (
 func init() {
 	modifier.Register(Ult, modifier.Config{
 		StatusType: model.StatusType_STATUS_BUFF,
+		Stacking:   modifier.ReplaceBySource,
+		CanDispel:  true,
 		Duration:   2,
 	})
 }

internal/character/clara/eidolon.go

@@ -19,11 +19,13 @@ func init() {
 	modifier.Register(E2, modifier.Config{
 		Stacking:   modifier.Refresh,
 		StatusType: model.StatusType_STATUS_BUFF,
+		CanDispel:  true,
 	})
 
 	modifier.Register(E4Buff, modifier.Config{
 		TickMoment: modifier.ModifierPhase1End,
 		StatusType: model.StatusType_STATUS_BUFF,
+		CanDispel:  true,
 	})
 
 	modifier.Register(E4, modifier.Config{

internal/character/clara/technique.go

@@ -15,6 +15,7 @@ const (
 func init() {
 	modifier.Register(Technique, modifier.Config{
 		StatusType: model.StatusType_STATUS_BUFF,
+		CanDispel:  true,
 		Duration:   2,
 	})
 }

internal/character/clara/ult.go

@@ -18,6 +18,7 @@ func init() {
 		BehaviorFlags: []model.BehaviorFlag{model.BehaviorFlag_STAT_BURST},
 		Stacking:      modifier.Refresh,
 		StatusType:    model.StatusType_STATUS_BUFF,
+		CanDispel:     true,
 		Duration:      2,
 	})
 

internal/character/danheng/skill.go

@@ -19,6 +19,7 @@ func init() {
 	modifier.Register(SkillSpeedDown, modifier.Config{
 		Stacking:      modifier.ReplaceBySource,
 		StatusType:    model.StatusType_STATUS_DEBUFF,
+		CanDispel:     true,
 		BehaviorFlags: []model.BehaviorFlag{model.BehaviorFlag_STAT_SPEED_DOWN},
 	})