Problems with deleteDatabase and import on Web

[vHrqO]

I ran into a problem when trying to delete and re-import a database in my web app.

I found #3460, but even with only one browser tab open,
I still hit the same error at this line:
InvalidStateError: Failed to read the 'error' property from 'IDBRequest': The request has not finished.

https://github.com/vHrqO/matcha/blob/8b07a2b3a0487d76cef38d1c939601a0efecc36b/matcha/lib/services/database_file/web.dart#L68

await info.deleteDatabase((drift_wasm.WebStorageApi.indexedDb, databaseName));

Also, when I use initializeDatabase in WasmProbeResult.open(), I close the previous connection once the import completes. However, if I call close(), the newly imported database fails to import successfully.

https://github.com/vHrqO/matcha/blob/8b07a2b3a0487d76cef38d1c939601a0efecc36b/matcha/lib/services/database_file/web.dart#L72

if (isIndexedDb) {
      final tmp = await info.open(
        drift_wasm.WasmStorageImplementation.sharedIndexedDb,
        databaseName,
        initializeDatabase: () async {
          return bytes;
        },
      );

      // await tmp.close();
    }

I’m wondering:

1. Does calling deleteDatabase earlier throw an error that prevents the import?
2. Is it incorrect to close the connection immediately after opening/importing?

Any ideas on how to properly delete and re-import the database on the web would be greatly appreciated!

[simolus3]

It's possible that deleteDatabase doesn't work because an existing database connection is still open.

However, if I call close(), the newly imported database fails to import successfully.

Drift initializes databases lazily on first access - can you try running e.g. await tmp.customStatement('SELECT 1;') before closing the database and see if that imports the database correctly?

[vHrqO]

Hi @simolus3

It's possible that deleteDatabase doesn't work because an existing database connection is still open.

I refactored the code to use a singleton to ensure the connection is closed
(there doesn’t seem to be an API to check if the connection is still open or closed.),
but I still get:

InvalidStateError: Failed to read the 'error' property from 'IDBRequest': The request has not finished.

Interestingly, the error is thrown only after the first call deleteDatabase (when I import the database again).
The first call succeeds, and even though it throws on the second call, it still appears to import successfully.

---

Drift initializes databases lazily on first access — can you try running, for example,
await tmp.customStatement('SELECT 1;')
before closing the database and see if that imports the database correctly?

I don’t think DatabaseConnection has a customStatement method, so I tried:

await connection.runCustom('SELECT 1;');

…but it throws:

RethrownDartError: LateInitializationError: Field '<name>' has not been initialized.

I can initialize the database and close it manually to emulate “first access” .

      final DatabaseConnection tmpConnection = await info.open(
        drift_wasm.WasmStorageImplementation.sharedIndexedDb,
        databaseName,
        initializeDatabase: () async {
          return bytes;
        },
      );

      // failed
      // RethrownDartError: LateInitializationError: Field '' has not been initialized.
      // await tmpConnection.runCustom('SELECT 1;');

      // work
      // random test query
      final tabDb = TabDbSingleton().db;
      await tabDb.getAllDistinctTags().get();
      await TabDbSingleton.release();

      //
      await tmpConnection.close();

---

RethrownDartError: LateInitializationError: Field '' has not been initialized.
drift_worker.js 828:25 Object.G
drift_worker.js 9750:10 hr.a8
drift_worker.js 8788:14
drift_worker.js 1616:63 oc.a
drift_worker.js 6211:14 oc.$2
drift_worker.js 6205:21 nY.$1
drift_worker.js 1837:19 Object.o8
drift_worker.js 12831:10 l6.$5
drift_worker.js 7087:12 io.be
drift_worker.js 6553:11 mE.$0
===== asynchronous gap ===========================
dart-sdk/lib/_internal/js_dev_runtime/patch/core_patch.dart 749:28 get current
package:drift/src/remote/communication.dart 113:66 request
package:drift/src/remote/client_impl.dart 101:28 [_runRequest]
package:drift/src/remote/client_impl.dart 116:12 runCustom
package:drift/src/runtime/api/connection.dart 113:16 runCustom
package:matcha/services/database_file/web.dart 84:26
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 623:19
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 648:23
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 594:19
dart-sdk/lib/async/zone.dart 1849:54 runUnary
dart-sdk/lib/async/future_impl.dart 224:18 handleValue
dart-sdk/lib/async/future_impl.dart 951:44 handleValueCallback
dart-sdk/lib/async/future_impl.dart 980:13 _propagateToListeners
dart-sdk/lib/async/future_impl.dart 723:5 [_completeWithValue]
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 504:7 complete
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 571:12 _asyncReturn
package:drift/src/web/wasm_setup.dart 331:3
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 623:19
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 648:23
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 594:19
dart-sdk/lib/async/zone.dart 1849:54 runUnary
dart-sdk/lib/async/future_impl.dart 224:18 handleValue
dart-sdk/lib/async/future_impl.dart 951:44 handleValueCallback
dart-sdk/lib/async/future_impl.dart 980:13 _propagateToListeners
dart-sdk/lib/async/future_impl.dart 723:5 [_completeWithValue]
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 504:7 complete
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 571:12 _asyncReturn
package:drift/remote.dart 201:1
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 623:19
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 648:23
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 594:19
dart-sdk/lib/async/zone.dart 1849:54 runUnary
dart-sdk/lib/async/future_impl.dart 224:18 handleValue
dart-sdk/lib/async/future_impl.dart 951:44 handleValueCallback
dart-sdk/lib/async/future_impl.dart 980:13 _propagateToListeners
dart-sdk/lib/async/future_impl.dart 723:5 [_completeWithValue]
dart-sdk/lib/async/future_impl.dart 807:7 callback
dart-sdk/lib/async/schedule_microtask.dart 42:13 _microtaskLoop
dart-sdk/lib/async/schedule_microtask.dart 60:5 _startMicrotaskLoop
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 118:77 tear
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 188:69

dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 307:10 createErrorWithStack
dart-sdk/lib/_internal/js_dev_runtime/private/profile.dart 118:39 _throw
dart-sdk/lib/core/errors.dart 120:5 throwWithStackTrace
dart-sdk/lib/async/zone.dart 1512:11 callback
dart-sdk/lib/async/schedule_microtask.dart 42:13 _microtaskLoop
dart-sdk/lib/async/schedule_microtask.dart 60:5 _startMicrotaskLoop
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 118:77 tear
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 188:69

[simolus3]

Sorry for the delayed response here. Wrapping tmpConnection in a database class should work as well:

      final db = TabDatabase(tmpConnection);
      await db.customStatement('SELECT 1');
      await db.close();

[vHrqO]

@simolus3

I found that this also happens if I call exportDatabase before import.
I believe the issue occurs on the second call to WasmDatabase.probe
Maybe the resource needs to be released ?

[simolus3]

It's a bit hard to see this from your project because the singleton around TabDatabase could open an independent connection. If you have a smaller project that reproduces this I'd be happy to take a look.