Error running "puppet resource iis_vdir"

[kupuguy]

When I try to display the current iis_vdir resources on a windows server 2008 R2 system I get this error:

C:>puppet resource iis_vdir
Error: Could not run: undefined method `end_with?' for nil:NilClass

I think the problem is that the code is not correctly reading the iis_app property from the current settings.

As a workaround (but not a fix) I added this code:

  if (iis_app.nil?)
      self[:iis_app] = iis_app = name
  end

just after the assignment to 'name' in the validate code of type/iis_vdir.rb This suppresses the validation and allows the code to run though the iis_app value is still missing from the output.

[lmayorga1980]

I also get the same error but never use puppet resource with this type
before.

On Tue, Dec 17, 2013 at 10:30 AM, Duncan Booth notifications@github.comwrote:

When I try to display the current iis_vdir resources on a windows server
2008 R2 system I get this error:

C:>puppet resource iis_vdir
Error: Could not run: undefined method `end_with?' for nil:NilClass

I think the problem is that the code is not correctly reading the iis_app
property from the current settings.

As a workaround (but not a fix) I added this code:

if (iis_app.nil?)
self[:iis_app] = iis_app = name
end

just after the assignment to 'name' in the validate code of
type/iis_vdir.rb This suppresses the validation and allows the code to run
though the iis_app value is still missing from the output.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/17
.

[kupuguy]

The same bug also triggers if you try to remove an existing iis_vdir:

iis_vdir { 'TestWebsite/': ensure => 'absent', }

Fails with the error "Failed to apply catalog: undefined method `end_with?' for nil:NilClass"

[dpotapov]

Hello, could somebody help with fixing this issue?
Actually I got puppet resource iis_vdir working for me after following changes:

Index: provider/iis/iis_object.rb                                                                        
===================================================================                                      
--- provider/iis/iis_object.rb                                                       
+++ provider/iis/iis_object.rb  (working copy)                                                           
@@ -73,6 +73,7 @@                                                                                        
       hash[:name] = item_xml.attributes["#{iis_type.upcase}.NAME"]                                      
       hash[:provider] = self.name                                                                       
       hash[:ensure] = :present                                                                          
+      hash[:iis_app] = item_xml.attributes["APP.NAME"] if iis_type == "vdir"                            
       items << hash                                                                                     
     end                                                                                                 

Index: type/iis_vdir.rb
===================================================================
--- type/iis_vdir.rb
+++ type/iis_vdir.rb    (working copy)
@@ -11,7 +11,7 @@
     newvalues(/.+\/.*/)
   end

-  newparam(:iis_app) do
+  newproperty(:iis_app) do
     desc "Path of the app the virtual directory is under"

     isrequired
@@ -45,25 +45,6 @@
     self[:iis_app]
   end

-  validate do
-    iis_app = self[:iis_app]
-    name = self[:name]
-
-    raise Puppet::Error, "name should start with '#{iis_app.chomp('/')}'" unless ensure_trailing_slash(name).start_with?(ensure_trailing_slash(iis_app))
-
-    iis_app = iis_app.chomp('/')
-    iis_app += '/' if iis_app.count('/') == 0
-
-    name = ensure_trailing_slash(name)
-
-    if name.length > ensure_trailing_slash(iis_app).length
-      name = name.chomp('/')
-    end
-
-    raise Puppet::Error, "iis_vdir name should be '#{name}'" unless self[:name] == name
-    raise Puppet::Error, "iis_vdir attribute iis_app should be set to '#{iis_app}'" unless self[:iis_app] == iis_app
-  end
-
   def ensure_trailing_slash(value)
     (value.end_with?('/')) ? value : (value + '/')
   end