fix: add getScriptKind to host for Vue JSX/TSX support#160
Open
susanforme wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: not working for Vue files with
<script lang="jsx">or<script lang="tsx">Problem
When using
prettier-plugin-organize-importswith Vue files that have<script lang="jsx">or<script lang="tsx">, unused imports are not removed and import sorting may silently fail.Root Cause
During decoration, Volar's
decorateLanguageServiceHostchecks whether the host provides agetScriptKindmethod. If this method is missing, Volar skips overridinggetScriptKind, which means TypeScript has no way to know that a virtual file generated from<script lang="jsx">should be parsed as JSX.TypeScript then defaults to treating the content as plain TS, fails to parse JSX syntax like
<div>, andorganizeImportsreturns an empty array — so no imports get removed.