[oss] Default flag(opt) to True

We want opt mode by default for Cabal builds, but assertions and debug
symbols for dev builds by default.

Author: simonmar

cabal.project

@@ -48,6 +48,10 @@ package thrift-tests
 package thrift-http
     ghc-options: -Werror
 
+-- Assertions and debug symbols on for dev builds
+package glean
+    flags: -opt
+
 package fb-util
     flags: +folly
 

glean.cabal.in

@@ -56,15 +56,18 @@ common fb-haskell
        ghc-options: -O2
 
 common fb-cpp
-  cxx-options: -std=c++17 -Wno-nullability-completeness
+  cxx-options: -std=c++17 -Wno-nullability-completeness -fno-omit-frame-pointer
   if !flag(clang)
      cxx-options: -fcoroutines
   if flag(asan)
      cxx-options: -fsanitize=address
   if arch(x86_64)
      cxx-options: -march=haswell
-  if flag(opt)
+  if flag(opt) && !flag(asan)
      cxx-options: -O3 -DNDEBUG
+  else
+     cc-options: -g
+     cxx-options: -g
   CXX_EXTRA_LIB_DIRS
 
 common exe
@@ -85,7 +88,7 @@ flag asan
      default: False
 
 flag opt
-     default: False
+     default: True
 
 flag benchmarks
      default: False