use _index_call everywhere

Summary:
We have two different functions to index calls.
1. index_build_rule
2. index_call

This diff makes 1 a specialized version of 2.

Besides, instead of trying to resolve strings to buck targets or source file paths only in 1, we now do it consistently for any string literal (when indexing expressions). This should generate many more target xrefs.

Reviewed By: malanka

Differential Revision: D84815018

fbshipit-source-id: 17b698938b3bcc3b6adbcbf892610d268a884347

Author: Philippe Bidinger

glean/glass/test/regression/tests/buck/documentSymbolIndex_my_defs.out

@@ -3,7 +3,7 @@
     {
         "referenced_file_digests": {},
         "revision": "testhash",
-        "size": 8,
+        "size": 10,
         "symbols": {
             "1": [
                 {
@@ -138,6 +138,72 @@
                         "lineEnd": 20
                     },
                     "sym": "test/buck/d/buck_project/my_defs.bzl/MY_LIST"
+                },
+                {
+                    "attributes": {
+                        "symbolKind": {
+                            "aInteger": 4
+                        },
+                        "symbolLanguage": {
+                            "aInteger": 11
+                        },
+                        "symbolName": {
+                            "aString": "toto.c"
+                        },
+                        "symbolParent": {
+                            "aString": "buck_project"
+                        }
+                    },
+                    "range": {
+                        "columnBegin": 35,
+                        "columnEnd": 43,
+                        "lineBegin": 20,
+                        "lineEnd": 20
+                    },
+                    "sym": "test/buck/f/buck_project/toto.c",
+                    "target": {
+                        "filepath": "buck_project/toto.c",
+                        "range": {
+                            "columnBegin": 1,
+                            "columnEnd": 2,
+                            "lineBegin": 1,
+                            "lineEnd": 1
+                        },
+                        "repository": "test"
+                    }
+                },
+                {
+                    "attributes": {
+                        "symbolKind": {
+                            "aInteger": 30
+                        },
+                        "symbolLanguage": {
+                            "aInteger": 11
+                        },
+                        "symbolName": {
+                            "aString": "bar"
+                        },
+                        "symbolParent": {
+                            "aString": "b"
+                        }
+                    },
+                    "range": {
+                        "columnBegin": 12,
+                        "columnEnd": 33,
+                        "lineBegin": 20,
+                        "lineEnd": 20
+                    },
+                    "sym": "test/buck/t/buck_project/PATH/b/bar",
+                    "target": {
+                        "filepath": "buck_project/b/TEST_TARGETS",
+                        "range": {
+                            "columnBegin": 1,
+                            "columnEnd": 2,
+                            "lineBegin": 11,
+                            "lineEnd": 13
+                        },
+                        "repository": "test"
+                    }
                 }
             ],
             "3": [

glean/glass/test/regression/tests/buck/findReferenceRanges_file.out

@@ -20,6 +20,16 @@
                 "lineEnd": 31
             },
             "repository": "test"
+        },
+        {
+            "filepath": "buck_project/my_defs.bzl",
+            "range": {
+                "columnBegin": 35,
+                "columnEnd": 43,
+                "lineBegin": 20,
+                "lineEnd": 20
+            },
+            "repository": "test"
         }
     ]
 ]

glean/glass/test/regression/tests/buck/findReferenceRanges_target.out

@@ -30,6 +30,16 @@
                 "lineEnd": 7
             },
             "repository": "test"
+        },
+        {
+            "filepath": "buck_project/my_defs.bzl",
+            "range": {
+                "columnBegin": 12,
+                "columnEnd": 33,
+                "lineBegin": 20,
+                "lineEnd": 20
+            },
+            "repository": "test"
         }
     ]
 ]