1.50: include directive's globs break when journal files are underneath a dotted directory

[psagers]

What I initially observed:

Success:

~> /usr/local/bin/hledger --version; /usr/local/bin/hledger check
hledger 1.43.2, linux-x86_64

Fail:

~> /usr/bin/hledger --version; /usr/bin/hledger check
hledger 1.50.3, linux-x86_64
hledger: Error: /home/[redacted]/.local/share/hledger/all.journal:1:1:
  |
1 | include global/*.journal
  | ^
No files were matched by glob pattern: global/*.journal

Old globs:

~> /usr/bin/hledger --version; /usr/bin/hledger check --old-glob
hledger 1.50.3, linux-x86_64

My journals are located under ~/.local, so this appears to be fallout from the exclusion of dotted directories from glob results. Presumably this change was only meant to prevent traversing dotted directories in the glob expansion, not to break any globs that happened to get evaluated entirely underneath a dotted directory.

[simonmichael]

You're right, this is bigger fallout from the new glob implementation than was expected or documented. Darn! Thanks for the report @psagers. You've earned the https://hledger.org/REGRESSIONS.html#regression-finder-bounty (please claim within 7 days).

[simonmichael]

PS to work around, add --old-glob to your ~/.hledger.conf for now.