set uc_att and dc_att but they do not remain set

[jennamo]

relocking then fails because it has NoneType attens

issue seen on crate 1 slots 5 and 7

[jlashner]

Hi Jenna, Daniel pretty much answered this in slack, but uxm_relock assumes that the attens in the config exist and are correct, so we need to set them in the cfg object. To do that, before running uxm_relock I did this for the other slots

ucs = [30, 20, 15, 15, 30, 20, 15, 15]
dcs = [30, 30, 30, 30, 30, 30, 30, 30]

for b in range(8):
    cfg.dev.bands{'uc_att'] = ucs[b]
    cfg.dev.bands{'uc_att'] = ucs[b]

before running:

uxm_relock.uxm_relock(S, cfg,  ...)

You can run cfg.dev.update_file() if you'd like, or you can just pass the modified cfg object to uxm_relock and it will write the updated cfg to disk (if it completes successfully).

[jennamo]

following the above sequence of events results in the same error

full traceback:

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
Cell In [59], line 1
----> 1 uxm_relock.uxm_relock(S, cfg=cfg, bands=cfg.dev.exp['active_bands'], show_plots=True)

File /usr/local/src/pysmurf/python/pysmurf/client/util/pub.py:50, in set_action.<locals>.dec.<locals>.wrapper(S, pub_action, *args, **kwargs)
     46             S.pub._action = func.__name__
     48         S.pub._action_ts = S.get_timestamp()
---> 50     rv = func(S, *args, **kwargs)
     52 finally:
     53     if is_top:

File /sodetlib/sodetlib/operations/uxm_relock.py:324, in uxm_relock(S, cfg, bands, show_plots, setup_notches, new_master_assignment, reset_rate_khz, nphi0, skip_setup_amps)
    322 band_cfg = cfg.dev.bands[band]
    323 S.set_synthesis_scale(band, exp['synthesis_scale'])
--> 324 S.set_att_uc(band, band_cfg['uc_att'])
    325 S.set_att_dc(band, band_cfg['dc_att'])
    326 S.set_band_delay_us(band, band_cfg['band_delay_us'])

File /usr/local/src/pysmurf/python/pysmurf/client/command/smurf_command.py:2610, in SmurfCommandMixin.set_att_uc(self, b, val, **kwargs)
   2608 att = int(self.band_to_att(b))
   2609 bay = self.band_to_bay(b)
-> 2610 self._caput(
   2611     self.att_root.format(bay) + self._uc_reg.format(att),
   2612     val, **kwargs)

File /usr/local/src/pysmurf/python/pysmurf/client/command/smurf_command.py:97, in SmurfCommandMixin._caput(self, cmd, val, write_log, execute, wait_before, wait_after, wait_done, log_level, enable_poll, disable_poll, new_epics_root, **kwargs)
     94     self.log(log_str, log_level)
     96 if execute and not self.offline:
---> 97     epics.caput(cmd, val, wait=wait_done, **kwargs)
     99 if wait_after is not None:
    100     if write_log:

File /usr/local/lib/python3.8/dist-packages/epics/__init__.py:105, in caput(pvname, value, wait, timeout, connection_timeout)
    103 if thispv.connected:
    104     timeout -= (time.time() - start_time)
--> 105     return thispv.put(value, wait=wait, timeout=timeout)

File /usr/local/lib/python3.8/dist-packages/epics/pv.py:47, in _ensure_context.<locals>.wrapped(self, *args, **kwargs)
     45     raise RuntimeError('Expected CA context is unset')
     46 elif expected_context == initial_context:
---> 47     return func(self, *args, **kwargs)
     49 # If not using the expected context, switch to it here:
     50 if initial_context is not None:

File /usr/local/lib/python3.8/dist-packages/epics/pv.py:652, in PV.put(self, value, wait, timeout, use_complete, callback, callback_data)
    646         callback(pvname=pvname, **kws)
    648 self._put_complete = (False
    649                       if use_complete
    650                       else None)
--> 652 return ca.put(self.chid, value,
    653               wait=wait, timeout=timeout,
    654               callback=_put_callback if use_complete or callback else None,
    655               callback_data=callback_data)

File /usr/local/lib/python3.8/dist-packages/epics/ca.py:616, in withConnectedCHID.<locals>.wrapper(*args, **kwds)
    612             fmt ="%s() timed out waiting '%s' to connect (%d seconds)"
    613             raise ChannelAccessException(fmt % (fcn.__name__,
    614                                         name(chid), timeout))
--> 616 return fcn(*args, **kwds)

File /usr/local/lib/python3.8/dist-packages/epics/ca.py:1693, in put(chid, value, wait, timeout, callback, callback_data, ftype)
   1691         value = [ord(i) for i in value] + [0, ]
   1692     else:
-> 1693         data[0] = value
   1694 else:
   1695     # allow strings (even bits/hex) to be put to integer types
   1696     if isinstance(value, (str, bytes)) and isinstance(data[0], (int, )):

TypeError: an integer is required (got type NoneType)

[jennamo]

oh jeez, just realized i'm using S.set_att instead of the cfg version, sorry

[jennamo]

ok even with using

ucs = [30, 20, 15, 15, 30, 20, 15, 15]
dcs = [30, 30, 30, 30, 30, 30, 30, 30]

for b in range(8):
    cfg.dev.bands[b]['uc_att'] = ucs[b]
    cfg.dev.bands[b]['uc_att'] = ucs[b]

i get the same error

[jennamo]

oop, both lines are setting UC. ok this works now. sorry for using gh discussions as my personal bug finder lol