add_group() sees files in 0.17.0 but does not in 0.18.1

[JonJagger]

I'm running some Ruby tests inside a docker container (Alpine 3.11)
The version of ruby inside the container is 2.6.5p114
My code is in a dir called /app (inside the image).
My tests are in a dir called /test (volume-mounted).
Note: the tests are not underneath the /app dir (and that is how I prefer it).

I get coverage of both the code (in /app) and the tests (in /test).
My coverage is setup like this..

require 'simplecov'

SimpleCov.start do
  filters.clear
  #add_group('debug') {|src| puts src.filename; false; }
  add_group('app') { |src| src.filename =~ %r"^/app/" }
  add_group('test') { |src| src.filename =~ %r"^/test/.*_test\.rb$" }
end
SimpleCov.root('/app')
SimpleCov.coverage_dir(ENV['COVERAGE_ROOT'])

My Gemfile.lock shows

simplecov (0.17.0)

All works fine.
I get coverage of the code.
I also get coverage of the tests (easy to keep this at 100%!)
:-)

When I move to simplecov 0.18.1 and leave everything else the same I am no longer getting any coverage of my tests (in /test). Uncommenting the line

  #add_group('debug') {|src| puts src.filename; false; }

shows that no /test/files are being seen at all.

[PragTob]

👋

Hi @JonJagger !

Thanks for your report!

I have a hunch that this might be due to you calling SimpleCov.root("/app") - could you try running it without this please?

I'm guessing that with filters.clear you want to remove it and maybe that doesn't work anymore.

One more thing, you should be able to call both root and coverage_dir within the SimpleCov.start block!

[JonJagger]

🤝
Hi
Thanks for the tips!

With 0.17.0, this works:

require 'simplecov'
SimpleCov.start do
  filters.clear
  #root('/app')
  coverage_dir(ENV['COVERAGE_ROOT'])
  add_group('debug') { |src| puts src.filename; false }
  add_group('app') { |src| src.filename =~ %r"^/app/" }
  add_group('test') { |src| src.filename =~ %r"^/test/.*_test\.rb$" }
end

It sees both /app/... and /test/...
Note I have commented out the call to root('/app')
Note it sees only /app/... if I comment out the line filters.clear

Switching to 0.18.1
It sees only /app/...
And it still sees only /app/... if I comment out the filters.clear

Thanks.

[PragTob]

@JonJagger hm that's... interesting. And weird. I have no idea how/why that is happening 🤷‍♂️

How do you run your tests? Aka what command is used? Where is the test setting invoked?

You don't happen to have a small repro reproducing it? I can try to reproduce it, but I fear I'll be out of luck because if we generally skipped test/ directories I think it'd show up somewhere else in our tests :|

e.g. https://github.com/colszowka/simplecov/blob/master/features/test_unit_basic.feature specifically tests they show up.

[JonJagger]

I will try to put together a small repo that reproduces the problem...
But not today.

[PragTob]

Sure, no hurry. Would be great if you did, otherwise reproduction is sadly quite hard :(

If you want to be extra cool, there's a test_projects part of our repo where we put such repos and write cukes against. But I can also just copy a repro repo in there :)

[JonJagger]

Had an unexpected few hours this evening...
https://github.com/JonJagger/possible-simplecov-bug

[PragTob]

@JonJagger thank you! 💚

For reference, you didn't manage to reproduce it without docker did you? I'll try without first and then well install docker and do that dance when I got time :)

[JonJagger]

No. I do everything inside docker nowadays. It is awesome.
If you want any help/advice re docker I'm happy to provide it.
By the way, I have a suspicion the problem is two sibling dirs directly off the root dir /
Cheers
Jon

[JonJagger]

@PragTob I'm still really hoping we can resolve this error together somehow. It is usually very easy to install docker. Once you've done that you'll be able to follow the readme on the repo I created: Run one script. Edit one file. Run the script again. That way you would at least have replicated the error :-)

[PragTob]

@JonJagger hey, yeah I know and have used docker but my experiences have been.. mixed. Just didn't have it on my desktop before, but Corona has changed that as well. I should be fine. I guess I'll have to put together a day/half a day one of these days to iron out some issues and make a new release. Still feel free to ping me again if I haven't in the next ~2 weeks 🤞 (albeit life is also relatively hectic these days)

[JonJagger]

Will do. Thanks :-)