Skip to content

Commit 81f5add

Browse files
fix(vitrify): fix local https certificates
1 parent 283ab67 commit 81f5add

2 files changed

Lines changed: 31 additions & 23 deletions

File tree

.changeset/swift-zoos-return.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'vitrify': patch
3+
---
4+
5+
fix(vitrify): fix local https certificates

packages/vitrify/src/node/bin/dev.ts

Lines changed: 26 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -65,24 +65,21 @@ export async function createVitrifyDevServer({
6565
if (ssr === 'fastify') ssrMode = 'fastify'
6666

6767
const wsPort = await getFirstOpenPort(24678)
68-
if (config.server?.https) {
69-
exitLogs.push(
70-
`[warning] HTTPS mode enabled. Visit https://{hostname}:${wsPort} to enable a security exception for HMR.`
71-
)
72-
}
7368

69+
const configBase = await baseConfig({
70+
framework,
71+
ssr: ssrMode,
72+
command: 'dev',
73+
mode: 'development',
74+
appDir,
75+
publicDir,
76+
base
77+
})
7478
config = await resolveConfig(
7579
{
76-
...(await baseConfig({
77-
framework,
78-
ssr: ssrMode,
79-
command: 'dev',
80-
mode: 'development',
81-
appDir,
82-
publicDir,
83-
base
84-
})),
80+
...configBase,
8581
server: {
82+
...configBase.server,
8683
host,
8784
port
8885
// hmr: {
@@ -94,6 +91,12 @@ export async function createVitrifyDevServer({
9491
'serve'
9592
)
9693

94+
if (config.server?.https) {
95+
exitLogs.push(
96+
`[warning] HTTPS mode enabled. Visit https://{hostname}:${wsPort} to enable a security exception for HMR.`
97+
)
98+
}
99+
97100
const vitrifyDevServer = await (
98101
await import('vite')
99102
).createServer({
@@ -104,16 +107,16 @@ export async function createVitrifyDevServer({
104107
define: {
105108
...config.define,
106109
__HOST__: `'${host}'`
110+
},
111+
server: {
112+
...config.server,
113+
host,
114+
port,
115+
hmr: {
116+
protocol: config.server?.https ? 'wss' : 'ws',
117+
port: wsPort
118+
}
107119
}
108-
// server: {
109-
// ...config.server,
110-
// host,
111-
// port,
112-
// hmr: {
113-
// protocol: config.server?.https ? 'wss' : 'ws',
114-
// port: wsPort
115-
// }
116-
// }
117120
})
118121

119122
return vitrifyDevServer

0 commit comments

Comments
 (0)