feat: implement --tag-via-sidecar when uploading#1131
feat: implement --tag-via-sidecar when uploading#1131niieani wants to merge 1 commit intosimulot:developfrom
--tag-via-sidecar when uploading#1131Conversation
9cfe87e to
27d80b5
Compare
…PIs as a workaround for [Immich #16747](immich-app/immich#16747)
27d80b5 to
c13981a
Compare
|
@simulot rebased on |
|
As per immich-app/immich#16747 (comment) I've tested this feature works, after the race condition issue in immich-app/immich#16747 was closed, but continues not to work for me with immich-go v0.21.0 and immich v2.4.1. Thanks for developing this feature, looking forward to seeing immich fix the tagging issue via API and/or this feature being merged into immich-go! Edit: One more commit to resolve immich-app/immich#16747 in immich-app/immich#25435 by the looks. |
|
I run my own tests based on the https://github.com/binarybumpkin method contents of 1.jpg.json |
fixes #990
Write tags into a temporary XMP sidecar before uploading, instead of using Immich tag APIs as a workaround for Immich's race condition in immich-app/immich#16747.
This means tags are attached as part of the initial POST asset upload, in the
sidecarDatamultipart, instead of as subsequent calls to Immich's API.If there's no sidecar, we create one (with just the tags), and if there is one, we losslessly modify its copy, by adding tags to it before sending it to Immich.
Changes