fix: ensure temporary file is closed properly in replaceDocxPlaceholders

Francisca105 · Francisca105 · commit 84b635a13da2 · 2026-01-23T11:05:38.000Z
diff --git a/backend/src/router/contract.go b/backend/src/router/contract.go
@@ -254,11 +254,14 @@ func replaceDocxPlaceholders(docxBytes []byte, replacements map[string]string, p
 	}
 	tmpSrcName := tmpSrc.Name()
 	defer func() {
-		tmpSrc.Close()
 		_ = os.Remove(tmpSrcName)
 	}()
 
 	if _, err := tmpSrc.Write(docxBytes); err != nil {
+		tmpSrc.Close()
+		return nil, err
+	}
+	if err := tmpSrc.Close(); err != nil {
 		return nil, err
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -254,11 +254,14 @@ func replaceDocxPlaceholders(docxBytes []byte, replacements map[string]string, p`
`254`	`254`	`}`
`255`	`255`	`tmpSrcName := tmpSrc.Name()`
`256`	`256`	`defer func() {`
`257`		`- tmpSrc.Close()`
`258`	`257`	`_ = os.Remove(tmpSrcName)`
`259`	`258`	`}()`
`260`	`259`
`261`	`260`	`if _, err := tmpSrc.Write(docxBytes); err != nil {`
	`261`	`+ tmpSrc.Close()`
	`262`	`+ return nil, err`
	`263`	`+ }`
	`264`	`+ if err := tmpSrc.Close(); err != nil {`
`262`	`265`	`return nil, err`
`263`	`266`	`}`
`264`	`267`