fix: assuming speaker and member gender

Author: jovitor1898

frontend/src/components/speakers/SpeakerCommunications.vue

@@ -13,10 +13,7 @@
 
 <script setup lang="ts">
 import { getSpeakerCommunications } from "@/api/speakers";
-import type {
-  SpeakerWithParticipation,
-  SpeakerWithContactObject,
-} from "@/dto/speakers";
+import type { SpeakerWithContactObject } from "@/dto/speakers";
 import { useEventStore } from "@/stores/event";
 import { usePostSpeakerThreadMutation } from "@/mutations/speakers";
 import Communications from "../Communications.vue";
@@ -25,7 +22,7 @@ import { computed } from "vue";
 import { useAuthStore } from "@/stores/auth";
 
 const props = defineProps<{
-  speaker: SpeakerWithParticipation;
+  speaker: SpeakerWithContactObject;
 }>();
 
 const eventStore = useEventStore();
@@ -44,10 +41,8 @@ const templates = computed(() =>
 
 const createSpeakerTemplateVariables = () => {
   const endDate = new Date(eventStore.selectedEvent?.end || 0);
-  const memberGender = authStore.member?.contactObject?.gender ?? "OTHER";
-  const speakerGender =
-    (props.speaker as SpeakerWithContactObject)?.contactObject?.gender ??
-    "OTHER";
+  const memberGender = authStore.member!.contactObject.gender;
+  const speakerGender = props.speaker.contactObject.gender;
 
   // Use contactObject which contains the full Contact (including gender)
   // Fallback to empty string when gender is unavailable to avoid runtime errors

frontend/src/lib/templates.ts

@@ -1,4 +1,4 @@
-import type { Speaker } from "@/dto/speakers";
+import type { SpeakerWithContactObject } from "@/dto/speakers";
 import type { Company } from "../dto/companies";
 import { ordinalSuffix } from "./utils";
 import {
@@ -114,7 +114,7 @@ export interface EmailVariableValueMap {
   [EmailVariableKey.EventEndYear]: Date;
   [EmailVariableKey.SpeakerArticle]: string;
   [EmailVariableKey.SpeakerSuffix]: string;
-  [EmailVariableKey.Speaker]: Speaker;
+  [EmailVariableKey.Speaker]: SpeakerWithContactObject;
   [EmailVariableKey.MemberArticle]: string;
   [EmailVariableKey.MemberSuffix]: string;
   [EmailVariableKey.Member]: MemberWithContact;
@@ -130,7 +130,7 @@ export interface VariablesInput {
   member: MemberWithContact;
 }
 export interface SpeakerVariablesInput extends VariablesInput {
-  speaker: Speaker;
+  speaker: SpeakerWithContactObject;
   paragraph?: string; // Optional paragraph for speaker emails
 }
 const isSpeakerVariablesInput = (
@@ -531,7 +531,9 @@ export const createEmailVariable = {
     value,
   }),
 
-  speaker: (value: Speaker): EmailVariableInput<EmailVariableKey.Speaker> => ({
+  speaker: (
+    value: SpeakerWithContactObject,
+  ): EmailVariableInput<EmailVariableKey.Speaker> => ({
     key: EmailVariableKey.Speaker,
     value,
   }),