Skip to content

Commit 14d367b

Browse files
committed
SAC-31205: addressed review comments
1 parent 0391413 commit 14d367b

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

tap_gitlab/client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ def __init__(self, config: Mapping[str, Any]) -> None:
7777
self.config = config
7878
self._session = session()
7979

80-
api_url = config.get("api_url", "https://gitlab.com").rstrip("/")
80+
api_url = (config.get("api_url") or "").strip() or "https://gitlab.com"
81+
api_url = api_url.rstrip("/")
8182
if not api_url.startswith(("http://", "https://")):
8283
api_url = f"https://{api_url}"
8384
# Strip any existing /api/vN suffix so both 'https://gitlab.com' and

tests/unittests/test_client.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,14 @@ def test_default_base_url_uses_gitlab_cloud(self):
110110
client = Client(config)
111111
self.assertEqual(client.base_url, "https://gitlab.com/api/v4")
112112

113+
def test_empty_api_url_falls_back_to_gitlab_cloud(self):
114+
"""An empty or whitespace-only api_url must fall back to gitlab.com."""
115+
for value in ["", " ", None]:
116+
with self.subTest(api_url=value):
117+
config = {"private_token": "dummy_token", "api_url": value}
118+
client = Client(config)
119+
self.assertEqual(client.base_url, "https://gitlab.com/api/v4")
120+
113121
def test_custom_api_url_sets_base_url(self):
114122
"""When api_url is set the client targets the on-prem instance."""
115123
config = {

0 commit comments

Comments
 (0)