Skip to content

[Bug] - 3D / 3Dfactorised parameter final_nonlin has no effect for cores with more than 1 layer #206

@vdobrev1

Description

@vdobrev1

@Mvystrcilova, @pollytur
For the Basic3dCore and Factorized3dCore in 3dcores.py the parameter final_nonlin has no effect if the core has more than 1 layer the reason for this is a if statement that is aways true in the loop that defines all layers after the first one.

In the for loop defined here the variable l takes values from 0 to number of layers - 2 and the condition a few lines after (line 183) compares l to self.layers. The result of this comparison is aways True by definition for l. The same holds for the for loop defined here and if condition here (line 430)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions