Merge pull request #96 from negbie/master

Fix bug found by fuzzer

Author: negbie

protos/fuzz.go

@@ -0,0 +1,18 @@
+// +build gofuzz
+
+package protos
+
+// To run the fuzzer, first download go-fuzz:
+// go get github.com/dvyukov/go-fuzz/...
+//
+// Then build the testing package:
+// go-fuzz-build github.com/negbie/heplify/protos
+//
+// And run the fuzzer
+//
+// go-fuzz -bin=fuzz-protos.zip -workdir=workdir
+
+func Fuzz(data []byte) int {
+	ParseRTCP(data)
+	return 0
+}

protos/rtcp.go

@@ -197,7 +197,7 @@ func ParseRTCP(data []byte) (ssrcBytes []byte, rtcpPkt []byte, infoMsg string) {
 	offset := 0
 
 	for dataLen > 0 {
-		if dataLen < 4 || dataLen > 576 || offset >= len(data) {
+		if dataLen < 4 || dataLen > 768 || offset > len(data)-4 {
 			infoMsg = fmt.Sprintf("Fishy RTCP dataLen=%d, offset=%d in packet:\n% X", dataLen, offset, data)
 			break
 		}