Fix Docker workflow dependencies by explicitly requiring test-dev-image

- Update `needs` to include both `build-dev-image` and `test-dev-image` for better dependency management
- Adjust conditional expressions to use `needs.<job>.result` instead of `jobs.<job>.result`

Signed-off-by: Phillip Sitbon <phillip.sitbon@gmail.com>

Author: sitbon

.github/workflows/docker-publish.yml

@@ -100,8 +100,8 @@ jobs:
     name: Push Dev Images
     runs-on: ubuntu-latest
 
-    needs: build-dev-image
-    if: ${{ always() && needs.build-dev-image.result == 'success' && (jobs.test-dev-image.result == 'success' || jobs.test-dev-image.result == 'skipped') }}
+    needs: [build-dev-image, test-dev-image]
+    if: ${{ always() && needs.build-dev-image.result == 'success' && (needs.test-dev-image.result == 'success' || needs.test-dev-image.result == 'skipped') }}
 
     permissions:
       contents: read
@@ -174,8 +174,8 @@ jobs:
     name: Build and Push Image
     runs-on: ubuntu-latest
 
-    needs: build-dev-image
-    if: ${{ always() && needs.build-dev-image.result == 'success' && (jobs.test-dev-image.result == 'success' || jobs.test-dev-image.result == 'skipped') }}
+    needs: [build-dev-image, test-dev-image]
+    if: ${{ always() && needs.build-dev-image.result == 'success' && (needs.test-dev-image.result == 'success' || needs.test-dev-image.result == 'skipped') }}
 
     permissions:
       contents: read