Is there any reason you don't add a height attribute to fallback image?

[ktallafus]

sms-responsive-images/Classes/Utility/ResponsiveImagesUtility.php

Line 221 in 1a559c1

$fallbackTag->addAttribute('width', $referenceWidth);

You could also do
$fallbackTag->addAttribute('height', $fallbackImage->getProperty('height'));
like it's done in f:media. Or am I missing something?

[s2b]

I think the reason for this was that the height value will be incorrect in most cases. By definition, the different sources of a picture tag will have different aspect ratios, so there can‘t be a correct height.

It can be argued that I should just choose the height of one variant or the one of the fallback image, but I‘m not sure what to choose here. Apart from that it would probably be a breaking change...

There probably will be a solution to that problem in the HTML5 specification:

https://twitter.com/jensimmons/status/1365066057774493697

[bernhardberger]

Btw. the viewhelper is broken when you use an image that doesn't have a width in sys_file_metadata (which can be the case when you're trying to use a file that isn't in your file storage but a static resource from your /Resources/Public/Images folder..)

[s2b]

Could you give me a concrete example? This worked for me:

<sms:image
    src="EXT:sms_responsive_images/Documentation/Images/AdministratorManual/ConstantsEditor.png"
    srcset="200, 400, 600"
    width="400"
/>