🐛 Fix encrypted asset external operations #18034

88250 · 88250 · commit 0c25b9c918b1 · 2026-08-01T00:57:28.000+08:00
diff --git a/app/src/asset/renderAssets.ts b/app/src/asset/renderAssets.ts
@@ -2,14 +2,14 @@ import {Constants} from "../constants";
 /// #if !MOBILE
 import {getAllModels} from "../layout/getAll";
 /// #endif
-import {pathPosix} from "../util/pathName";
+import {getAssetExtension} from "../util/pathName";
 import * as dayjs from "dayjs";
 
 export const renderAssetsPreview = (pathString: string) => {
     if (!pathString) {
         return "";
     }
-    const type = pathPosix().extname(pathString).toLowerCase();
+    const type = getAssetExtension(pathString).toLowerCase();
     if (Constants.SIYUAN_ASSETS_IMAGE.includes(type)) {
         return `<img style="max-height: 100%" src="${pathString}">`;
     } else if (Constants.SIYUAN_ASSETS_AUDIO.includes(type)) {
diff --git a/app/src/editor/openLink.ts b/app/src/editor/openLink.ts
@@ -1,4 +1,4 @@
-import {isLocalPath, pathPosix} from "../util/pathName";
+import {getAssetExtension, isLocalPath} from "../util/pathName";
 /// #if !BROWSER
 import {shell} from "electron";
 /// #endif
@@ -32,11 +32,12 @@ export const openLink = (app: App, aLink: string, event?: MouseEvent, ctrlIsPres
     openByMobile(linkAddress);
     /// #else
     if (isLocalPath(linkAddress)) {
-        if (Constants.SIYUAN_ASSETS_EXTS.includes(pathPosix().extname(linkAddress)) &&
+        const extension = getAssetExtension(linkAddress);
+        if (Constants.SIYUAN_ASSETS_EXTS.includes(extension) &&
             (
-                !linkAddress.endsWith(".pdf") ||
+                extension !== ".pdf" ||
                 // 本地 pdf 仅 assets/ 开头的才使用 siyuan 打开
-                (linkAddress.endsWith(".pdf") && linkAddress.startsWith("assets/"))
+                (extension === ".pdf" && linkAddress.startsWith("assets/"))
             )
         ) {
             if (event && event.altKey) {
diff --git a/app/src/editor/util.ts b/app/src/editor/util.ts
@@ -5,7 +5,7 @@ import {getInstanceById, getWndByLayout, newModelByInitData, pdfIsLoading, setPa
 import {getDockByType} from "../layout/tabUtil";
 import {getAllModels, getAllTabs} from "../layout/getAll";
 import {highlightById, scrollCenter} from "../util/highlightById";
-import {getDisplayName, getDocDisplayName, isEncryptedBox, pathPosix, useShell} from "../util/pathName";
+import {getAssetExtension, getDisplayName, getDocDisplayName, isEncryptedBox, useShell} from "../util/pathName";
 import {Constants} from "../constants";
 import {Files} from "../layout/dock/Files";
 import {fetchPost, fetchSyncPost} from "../util/fetch";
@@ -90,7 +90,7 @@ export const openFileById = async (options: {
 };
 
 export const openAsset = (app: App, assetPath: string, page: number | string, position?: string) => {
-    const suffix = pathPosix().extname(assetPath).split("?")[0];
+    const suffix = getAssetExtension(assetPath);
     if (!Constants.SIYUAN_ASSETS_EXTS.includes(suffix)) {
         return;
     }
@@ -491,7 +491,7 @@ const switchEditor = (editor: Editor, options: IOpenFileOptions, allModels: IMod
 const newTab = (options: IOpenFileOptions) => {
     let tab: Tab;
     if (options.assetPath) {
-        const suffix = pathPosix().extname(options.assetPath).split("?")[0];
+        const suffix = getAssetExtension(options.assetPath);
         if (Constants.SIYUAN_ASSETS_EXTS.includes(suffix)) {
             let icon = "iconPDF";
             if (Constants.SIYUAN_ASSETS_IMAGE.includes(suffix)) {
diff --git a/app/src/menus/commonMenuItem.ts b/app/src/menus/commonMenuItem.ts
@@ -3,7 +3,7 @@ import {shell} from "electron";
 /// #endif
 import {confirmDialog} from "../dialog/confirmDialog";
 import {getSearch, isMobile, isValidCustomAttrName} from "../util/functions";
-import {isEncryptedBox, isLocalPath, movePathTo, moveToPath, pathPosix} from "../util/pathName";
+import {getAssetExtension, isEncryptedBox, isLocalPath, movePathTo, moveToPath, pathPosix} from "../util/pathName";
 import {MenuItem} from "./Menu";
 import {onExport, saveExport} from "../protyle/export";
 import {exportMarkdownZip} from "../protyle/export/exportMd";
@@ -853,9 +853,10 @@ export const openMenu = (app: App, src: string, onlyMenu: boolean, showAccelerat
     });
     /// #else
     if (isLocalPath(src)) {
-        if (Constants.SIYUAN_ASSETS_EXTS.includes(pathPosix().extname(src).split("?")[0]) &&
-            (!src.endsWith(".pdf") ||
-                (src.endsWith(".pdf") && !src.startsWith("file://")))
+        const extension = getAssetExtension(src);
+        if (Constants.SIYUAN_ASSETS_EXTS.includes(extension) &&
+            (extension !== ".pdf" ||
+                (extension === ".pdf" && !src.startsWith("file://")))
         ) {
             submenu.push({
                 id: "insertRight",
diff --git a/app/src/menus/util.ts b/app/src/menus/util.ts
@@ -3,7 +3,7 @@ import {ipcRenderer} from "electron";
 import * as path from "path";
 /// #endif
 import {fetchPost} from "../util/fetch";
-import {getAssetName, pathPosix, useShell} from "../util/pathName";
+import {getAssetExtension, getAssetName, useShell} from "../util/pathName";
 import {openFileById} from "../editor/util";
 import {Constants} from "../constants";
 import {openNewWindowById} from "../window/openNewWindow";
@@ -26,7 +26,7 @@ export const exportAsset = (src: string) => {
             /// #else
             const result = await ipcRenderer.invoke(Constants.SIYUAN_GET, {
                 cmd: "showSaveDialog",
-                defaultPath: getAssetName(src) + pathPosix().extname(src),
+                defaultPath: getAssetName(src) + getAssetExtension(src),
                 properties: ["showOverwriteConfirmation"],
             });
             if (!result.canceled) {
diff --git a/app/src/protyle/hint/extend.ts b/app/src/protyle/hint/extend.ts
@@ -11,7 +11,7 @@ import {hasClosestBlock, hasClosestByClassName} from "../util/hasClosest";
 import {getContenteditableElement, getTopAloneElement} from "../wysiwyg/getBlock";
 import {replaceFileName} from "../../editor/rename";
 import {transaction} from "../wysiwyg/transaction";
-import {getAssetName, getDisplayName, isEncryptedBox, pathPosix} from "../../util/pathName";
+import {getAssetExtension, getAssetName, getDisplayName, isEncryptedBox} from "../../util/pathName";
 import {genEmptyElement} from "../../block/util";
 import {updateListOrder} from "../wysiwyg/list";
 import {escapeHtml} from "../../util/escape";
@@ -604,7 +604,7 @@ export const hintRenderWidget = (value: string, protyle: IProtyle) => {
 
 export const hintRenderAssets = (value: string, protyle: IProtyle) => {
     focusByRange(protyle.toolbar.range);
-    const type = pathPosix().extname(value).toLowerCase();
+    const type = getAssetExtension(value).toLowerCase();
     const filename = value.startsWith("assets/") ? getAssetName(value) : value;
     insertHTML(genAssetHTML(type, value, filename, value.startsWith("assets/") ? filename + type : value), protyle);
     hideElements(["util"], protyle);
diff --git a/app/src/protyle/render/av/asset.ts b/app/src/protyle/render/av/asset.ts
@@ -4,7 +4,7 @@ import {updateAttrViewCellAnimation} from "./action";
 import {isMobile} from "../../../util/functions";
 import {Constants} from "../../../constants";
 import {uploadFiles} from "../../upload";
-import {pathPosix} from "../../../util/pathName";
+import {getAssetExtension, pathPosix} from "../../../util/pathName";
 import {openMenu} from "../../../menus/commonMenuItem";
 import {MenuItem} from "../../../menus/Menu";
 import {copyPNGByLink, exportAsset, writeAssetToClipboard} from "../../../menus/util";
@@ -46,7 +46,7 @@ export const bindAssetEvent = (options: {
                 value.push({
                     name: key,
                     content: resData.data.succMap[key],
-                    type: Constants.SIYUAN_ASSETS_IMAGE.includes(pathPosix().extname(resData.data.succMap[key]).toLowerCase()) ? "image" : "file"
+                    type: Constants.SIYUAN_ASSETS_IMAGE.includes(getAssetExtension(resData.data.succMap[key]).toLowerCase()) ? "image" : "file"
                 });
             });
             updateAssetCell({
diff --git a/app/src/protyle/render/av/cell.ts b/app/src/protyle/render/av/cell.ts
@@ -12,7 +12,7 @@ import {getColIconByType, getColId} from "./col";
 import {genAVValueHTML, getAVTemplateHTML} from "./attributeValue";
 import {Constants} from "../../../constants";
 import {hintRef} from "../../hint/extend";
-import {getAssetName, pathPosix} from "../../../util/pathName";
+import {getAssetExtension, getAssetName} from "../../../util/pathName";
 import {mergeAddOption} from "./select";
 import {escapeAriaLabel, escapeAttr, escapeHtml} from "../../../util/escape";
 import {electronUndo} from "../../undo";
@@ -230,7 +230,7 @@ const transformCellValue = (colType: TAVCol, value: IAVCellValue): IAVCellValue
     } else if (colType === "mAsset") {
         const content = getCellValueContent(value).toString();
         newValue.mAsset = [{
-            type: Constants.SIYUAN_ASSETS_IMAGE.includes(pathPosix().extname(content).toLowerCase()) ? "image" : "file",
+            type: Constants.SIYUAN_ASSETS_IMAGE.includes(getAssetExtension(content).toLowerCase()) ? "image" : "file",
             content,
             name: "",
         }];
@@ -302,7 +302,7 @@ export const genCellValue = (colType: TAVCol, value: string | any, dateFormat: T
                 relation: {blockIDs: [value], contents: []}
             };
         } else if (colType === "mAsset") {
-            const type = pathPosix().extname(value).toLowerCase();
+            const type = getAssetExtension(value).toLowerCase();
             cellValue = {
                 type: colType,
                 mAsset: [{
@@ -842,7 +842,7 @@ export const updateCellsValue = async (protyle: IProtyle, nodeElement: HTMLEleme
                 // https://github.com/siyuan-note/siyuan/issues/13892
                 if (!link && value.startsWith("assets/")) {
                     link = value;
-                    name = getAssetName(value) + pathPosix().extname(value);
+                    name = getAssetName(value) + getAssetExtension(value);
                 }
                 // https://github.com/siyuan-note/siyuan/issues/12308
                 if (html) {
diff --git a/app/src/protyle/render/av/openMenuPanel.ts b/app/src/protyle/render/av/openMenuPanel.ts
@@ -38,7 +38,7 @@ import {updateAttrViewCellAnimation} from "./action";
 import {addAssetLink, bindAssetEvent, editAssetItem, getAssetHTML, updateAssetCell} from "./asset";
 import {Constants} from "../../../constants";
 import {hideElements} from "../../ui/hideElements";
-import {pathPosix} from "../../../util/pathName";
+import {getAssetExtension} from "../../../util/pathName";
 import {openEmojiPanel, unicode2Emoji} from "../../../emoji";
 import {isMobile} from "../../../util/functions";
 import {openLink} from "../../../editor/openLink";
@@ -1751,7 +1751,7 @@ export const openMenuPanel = (options: {
                         h: rect.height
                     }, (url, name) => {
                         let value: IAVCellAssetValue;
-                        if (Constants.SIYUAN_ASSETS_IMAGE.includes(pathPosix().extname(url).toLowerCase())) {
+                        if (Constants.SIYUAN_ASSETS_IMAGE.includes(getAssetExtension(url).toLowerCase())) {
                             value = {
                                 type: "image",
                                 content: url,
diff --git a/app/src/util/pathName.ts b/app/src/util/pathName.ts
@@ -154,8 +154,17 @@ export const getDocDisplayName = (name: string, titleEmpty?: boolean, escape?: b
     return displayName;
 };
 
+export const getAssetPathWithoutQuery = (assetPath: string) => {
+    return assetPath.split("?", 1)[0];
+};
+
+export const getAssetExtension = (assetPath: string) => {
+    return pathPosix().extname(getAssetPathWithoutQuery(assetPath));
+};
+
 export const getAssetName = (assetPath: string) => {
-    return pathPosix().basename(assetPath, pathPosix().extname(assetPath)).replace(/-\d{14}-\w{7}/, "");
+    const pathWithoutQuery = getAssetPathWithoutQuery(assetPath);
+    return pathPosix().basename(pathWithoutQuery, getAssetExtension(pathWithoutQuery)).replace(/-\d{14}-\w{7}/, "");
 };
 
 export const isLocalPath = (link: string) => {
diff --git a/app/src/window/openNewWindow.ts b/app/src/window/openNewWindow.ts
@@ -6,7 +6,7 @@ import {Constants} from "../constants";
 import {Tab} from "../layout/Tab";
 import {fetchSyncPost} from "../util/fetch";
 import {showMessage} from "../dialog/message";
-import {getDisplayName, pathPosix} from "../util/pathName";
+import {getAssetExtension, getDisplayName} from "../util/pathName";
 import {getSearch} from "../util/functions";
 
 interface windowOptions {
@@ -77,7 +77,7 @@ export const openNewWindowById = async (id: string | string[], options: windowOp
 
 export const openAssetNewWindow = (assetPath: string, options: windowOptions = {}) => {
     /// #if !BROWSER
-    const suffix = pathPosix().extname(assetPath).split("?")[0];
+    const suffix = getAssetExtension(assetPath);
     if (Constants.SIYUAN_ASSETS_EXTS.includes(suffix)) {
         let docIcon = "iconPDF";
         if (Constants.SIYUAN_ASSETS_IMAGE.includes(suffix)) {
diff --git a/kernel/api/asset.go b/kernel/api/asset.go
@@ -478,19 +478,13 @@ func resolveAssetPath(c *gin.Context) {
 	}
 
 	path := arg["path"].(string)
-	p, err := model.GetAssetAbsPathInBox(path, "")
+	p, err := model.PrepareAssetForOpen(path)
 	if err != nil {
 		ret.Code = -1
 		ret.Msg = err.Error()
 		ret.Data = map[string]any{"closeTimeout": 3000}
 		return
 	}
-	if model.IsEncryptedAssetPath(p) {
-		ret.Code = -1
-		ret.Msg = model.Conf.Language(314)
-		ret.Data = map[string]any{"closeTimeout": 3000}
-		return
-	}
 	ret.Data = p
 	return
 }
diff --git a/kernel/api/clipboard.go b/kernel/api/clipboard.go
@@ -72,20 +72,14 @@ func writeFilePath(c *gin.Context) {
 		return
 	}
 
-	absPath, err := model.GetAssetAbsPathInBox(pathArg, "")
+	absPath, err := model.PrepareAssetForOpen(pathArg)
 	if err != nil {
 		logging.LogErrorf("get asset [%s] abs path failed: %s", pathArg, err)
 		ret.Code = -1
 		ret.Msg = err.Error()
 		ret.Data = map[string]any{"closeTimeout": 5000}
 		return
 	}
-	if model.IsEncryptedAssetPath(absPath) {
-		ret.Code = -1
-		ret.Msg = model.Conf.Language(314)
-		ret.Data = map[string]any{"closeTimeout": 5000}
-		return
-	}
 
 	if err = util.WriteFilePaths([]string{absPath}); err != nil {
 		logging.LogErrorf("write file path to clipboard failed: %s", err)
diff --git a/kernel/model/asset_open.go b/kernel/model/asset_open.go
@@ -0,0 +1,117 @@
+// SiYuan - Refactor your thinking
+// Copyright (c) 2020-present, b3log.org
+//
+// This program is free software: you can redistribute it and/or modify
+// it under the terms of the GNU Affero General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// This program is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU Affero General Public License for more details.
+//
+// You should have received a copy of the GNU Affero General Public License
+// along with this program. If not, see <https://www.gnu.org/licenses/>.
+
+package model
+
+import (
+	"errors"
+	"os"
+	"path/filepath"
+	"strings"
+
+	"github.com/siyuan-note/filelock"
+	"github.com/siyuan-note/siyuan/kernel/util"
+)
+
+// PrepareAssetForOpen 返回可交给系统应用打开的资源绝对路径。
+// 加密资源会流式解密到按 box 隔离的临时目录，该目录在笔记本锁定或内核下次启动时清理。
+func PrepareAssetForOpen(assetPath string) (ret string, err error) {
+	assetAbsPath, err := GetAssetAbsPathInBox(assetPath, "")
+	if err != nil {
+		return "", err
+	}
+	if !IsEncryptedAssetPath(assetAbsPath) {
+		return assetAbsPath, nil
+	}
+
+	boxID := ExtractBoxIDFromAssetsPath(assetAbsPath)
+	if err = AcquireEncryptedBoxOperation(boxID); err != nil {
+		return "", errors.New(Conf.Language(314))
+	}
+	defer ReleaseEncryptedBoxOperation(boxID)
+	HoldBoxReadLock(boxID)
+	defer ReleaseBoxReadLock(boxID)
+
+	dek, err := GetDEKIfUnlocked(boxID)
+	if err != nil {
+		return "", errors.New(Conf.Language(314))
+	}
+	defer zeroAndClear(dek)
+	if strings.TrimSpace(util.TempDir) == "" {
+		return "", errors.New("temporary directory is not initialized")
+	}
+
+	openID, err := newManagedEncryptedExportID()
+	if err != nil {
+		return "", err
+	}
+	tempDir := filepath.Join(util.TempDir, "export", boxID, "asset-open", openID)
+	if err = os.MkdirAll(tempDir, 0700); err != nil {
+		return "", err
+	}
+	cleanup := true
+	defer func() {
+		if cleanup {
+			_ = os.RemoveAll(tempDir)
+		}
+	}()
+
+	source, err := filelock.OpenFile(assetAbsPath, os.O_RDONLY, 0)
+	if err != nil {
+		return "", err
+	}
+	sourceOpen := true
+	defer func() {
+		if sourceOpen {
+			_ = filelock.CloseFile(source)
+		}
+	}()
+
+	payloadPath := filepath.Join(tempDir, "payload")
+	destination, err := os.OpenFile(payloadPath, os.O_CREATE|os.O_EXCL|os.O_WRONLY, 0600)
+	if err != nil {
+		return "", err
+	}
+	originalName, decryptErr := DecryptAssetToWriter(boxID, filepath.Base(assetAbsPath), dek, source, destination)
+	sourceCloseErr := filelock.CloseFile(source)
+	sourceOpen = false
+	destinationCloseErr := destination.Close()
+	if decryptErr != nil {
+		return "", decryptErr
+	}
+	if sourceCloseErr != nil {
+		return "", sourceCloseErr
+	}
+	if destinationCloseErr != nil {
+		return "", destinationCloseErr
+	}
+
+	originalName = util.FilterFileName(filepath.Base(originalName))
+	if originalName == "" || originalName == "." {
+		originalName = filepath.Base(assetAbsPath)
+	}
+	ret = filepath.Join(tempDir, originalName)
+	if ret != payloadPath {
+		if err = os.Rename(payloadPath, ret); err != nil {
+			return "", err
+		}
+	}
+	if err = os.Chmod(ret, 0600); err != nil {
+		return "", err
+	}
+	cleanup = false
+	return ret, nil
+}
diff --git a/kernel/model/asset_open_test.go b/kernel/model/asset_open_test.go
diff --git a/kernel/model/import.go b/kernel/model/import.go
diff --git a/kernel/model/import_test.go b/kernel/model/import_test.go
