Replace the deprecated isSameNode method in DOM Level 4 with the === operator (#15347)

Author: TCOTC

app/src/ai/actions.ts

@@ -255,7 +255,7 @@ export const AIActions = (elements: Element[], protyle: IProtyle) => {
             });
             element.addEventListener("click", (event) => {
                 let target = event.target as HTMLElement;
-                while (target && !target.isSameNode(element)) {
+                while (target && (target !== element)) {
                     if (target.classList.contains("b3-list-item__action")) {
                         const subItem = window.siyuan.storage[Constants.LOCAL_AI][target.parentElement.dataset.index];
                         editDialog(subItem.name, subItem.memo);

app/src/block/popover.ts

@@ -117,7 +117,7 @@ export const initBlockPopover = (app: App) => {
                     const boxData = response.data.boxInfo;
                     const tip = `${boxData.name} <small class='ft__on-surface'>${boxData.hSize}</small>${boxData.docCount !== 0 ? window.siyuan.languages.includeSubFile.replace("x", boxData.docCount) : ""}<br>${window.siyuan.languages.modifiedAt} ${boxData.hMtime}<br>${window.siyuan.languages.createdAt} ${boxData.hCtime}`;
                     const scopeNotebookItemElement = hasClosestByClassName(event.target, "b3-list-item__text");
-                    if (notebookItemElement && scopeNotebookItemElement && notebookItemElement.isSameNode(scopeNotebookItemElement)) {
+                    if (notebookItemElement && scopeNotebookItemElement && (notebookItemElement === scopeNotebookItemElement)) {
                         showTooltip(tip, notebookItemElement);
                     }
                     if (scopeNotebookItemElement &&
@@ -242,7 +242,7 @@ const hidePopover = (event: MouseEvent & { path: HTMLElement[] }) => {
     if (!popoverTargetElement && linkElement && linkElement.getAttribute("data-href")?.startsWith("siyuan://blocks")) {
         popoverTargetElement = linkElement;
     }
-    if (!popoverTargetElement || (popoverTargetElement && window.siyuan.menus.menu.data?.isSameNode(popoverTargetElement))) {
+    if (!popoverTargetElement || (popoverTargetElement && window.siyuan.menus.menu.data && (window.siyuan.menus.menu.data === popoverTargetElement))) {
         // 移动到弹窗的 loading 元素上，但经过 settimeout 后 loading 已经被移除了
         // https://ld246.com/article/1673596577519/comment/1673767749885#comments
         let targetElement = target;
@@ -356,7 +356,7 @@ const getTarget = (event: MouseEvent & { target: HTMLElement }, aElement: false
 };
 
 export const showPopover = async (app: App, showRef = false) => {
-    if (!popoverTargetElement || window.siyuan.menus.menu.data?.isSameNode(popoverTargetElement)) {
+    if (!popoverTargetElement || (window.siyuan.menus.menu.data && (window.siyuan.menus.menu.data === popoverTargetElement))) {
         return;
     }
     let refDefs: IRefDefs[] = [];

app/src/boot/globalEvent/keydown.ts

@@ -80,7 +80,7 @@ import {bindAVPanelKeydown} from "../../protyle/render/av/keydown";
 const switchDialogEvent = (app: App, event: MouseEvent) => {
     event.preventDefault();
     let target = event.target as HTMLElement;
-    while (!target.isSameNode(switchDialog.element)) {
+    while (target !== switchDialog.element) {
         if (target.classList.contains("b3-list-item")) {
             const currentType = target.getAttribute("data-type");
             if (currentType) {

app/src/boot/globalEvent/mousemove.ts

@@ -111,7 +111,7 @@ export const windowMouseMove = (event: MouseEvent, mouseIsEnter: boolean) => {
             const allModels = getAllModels();
             let findNode = false;
             allModels.editor.find(item => {
-                if (item.editor.protyle.wysiwyg.element.isSameNode(eventPath0)) {
+                if (item.editor.protyle.wysiwyg.element === eventPath0) {
                     item.editor.protyle.gutter.render(item.editor.protyle, targetBlockElement, item.editor.protyle.wysiwyg.element, rowElement);
                     findNode = true;
                     return true;
@@ -134,7 +134,7 @@ export const windowMouseMove = (event: MouseEvent, mouseIsEnter: boolean) => {
             if (!findNode) {
                 allModels.backlink.find(item => {
                     item.editors.find(eItem => {
-                        if (eItem.protyle.wysiwyg.element.isSameNode(eventPath0)) {
+                        if (eItem.protyle.wysiwyg.element === eventPath0) {
                             eItem.protyle.gutter.render(eItem.protyle, targetBlockElement, eItem.protyle.wysiwyg.element, rowElement);
                             findNode = true;
                             return true;

app/src/card/makeCard.ts

@@ -71,7 +71,7 @@ export const makeCard = (app: App, ids: string[]) => {
         dialog.element.setAttribute("data-key", Constants.DIALOG_MAKECARD);
         dialog.element.addEventListener("click", (event) => {
             let target = event.target as HTMLElement;
-            while (target && !target.isSameNode(dialog.element)) {
+            while (target && (target !== dialog.element)) {
                 const type = target.getAttribute("data-type");
                 if (type === "create") {
                     let msgId = "";

app/src/card/viewCards.ts

@@ -115,7 +115,7 @@ export const viewCards = (app: App, deckID: string, title: string, deckType: "Tr
                 return;
             }
             let target = event.target as HTMLElement;
-            while (target && !dialog.element.isSameNode(target)) {
+            while (target && (dialog.element !== target)) {
                 const type = target.getAttribute("data-type");
                 if (type === "close") {
                     dialog.destroy();

app/src/config/keymap.ts

@@ -475,7 +475,7 @@ export const keymap = {
                         hasConflict = true;
                     }
                     Array.from(keymap.element.querySelectorAll("label.b3-list-item input")).find((inputItem: HTMLElement) => {
-                        if (!inputItem.isSameNode(this) && inputItem.getAttribute("data-value") === keymapStr) {
+                        if ((inputItem !== this) && inputItem.getAttribute("data-value") === keymapStr) {
                             const inputValueList = inputItem.getAttribute("data-key").split(Constants.ZWSP);
                             if (inputValueList[1] === "list") {
                                 inputValueList[1] = "list1";

app/src/config/util/snippets.ts

@@ -114,7 +114,7 @@ export const openSnippets = () => {
         dialog.element.setAttribute("data-key", Constants.DIALOG_SNIPPETS);
         dialog.element.addEventListener("click", (event) => {
             let target = event.target as HTMLElement;
-            while (target && !target.isSameNode(dialog.element)) {
+            while (target && (target !== dialog.element)) {
                 if (target.id === "addCodeSnippetCSS" || target.id === "addCodeSnippetJS") {
                     target.parentElement.insertAdjacentHTML("afterend", genSnippet({
                         type: target.id === "addCodeSnippetCSS" ? "css" : "js",

app/src/dialog/confirmDialog.ts

@@ -25,7 +25,7 @@ export const confirmDialog = (title: string, text: string,
     dialog.element.addEventListener("click", (event) => {
         let target = event.target as HTMLElement;
         const isDispatch = typeof event.detail === "string";
-        while (target && !target.isSameNode(dialog.element) || isDispatch) {
+        while (target && (target !== dialog.element) || isDispatch) {
             if (target.id === "cancelDialogConfirmBtn" || (isDispatch && event.detail=== "Escape")) {
                 if (cancel) {
                     cancel(dialog);

app/src/dialog/message.ts

@@ -12,7 +12,7 @@ export const initMessage = () => {
                 hideMessage(target.parentElement.getAttribute("data-id"));
                 event.preventDefault();
                 break;
-            } else if (target.isSameNode(messageElement.lastElementChild)) {
+            } else if (target === messageElement.lastElementChild) {
                 target.parentElement.classList.remove("b3-snackbars--show");
                 setTimeout(() => {
                     target.parentElement.firstElementChild.innerHTML = "";