调整代码写法

Author: TCOTC

app/src/config/index.ts

@@ -74,12 +74,7 @@ const openSettingDialog = (app: App, initialTab: TConfigTab = "editor") => {
     });
     dialog.element.setAttribute("data-key", Constants.DIALOG_SETTING);
 
-    const tabWrap = dialog.element.querySelector(".config__tab-wrap") as HTMLElement | null;
-    if (!tabWrap) {
-        console.error("openSettingDialog: .config__tab-wrap not found");
-        dialog.destroy();
-        return;
-    }
+    const tabWrap = dialog.element.querySelector(".config__tab-wrap") as HTMLElement;
     bindSettingSaveDelegation(tabWrap);
     initConfigSearch(dialog.element, app);
     (dialog.element.querySelector(".b3-dialog__container") as HTMLElement).style.maxWidth = "1280px";

app/src/config/search.ts

@@ -1,6 +1,6 @@
 import type {TConfigTab} from "./types";
 import {getConfigTabDefs} from "./tabs";
-import {collectSettingTabSearchStrings, textMatchesConfigSearch} from "./ui/search";
+import {collectSettingTabSearchStrings, textMatchesSearch} from "./ui/search";
 import {buildEditorSections, editorSettings} from "./editor";
 import {buildFileSections, fileSettings} from "./file";
 import {buildAppearanceSections, appearanceSettings} from "./appearance";
@@ -270,6 +270,8 @@ const getTabSearchStrings = (tabId: TConfigTab): string[] => {
 export const initConfigSearch = (element: HTMLElement, app: App) => {
     const tabSearchStrings = getConfigTabDefs().map((def) => ({
         id: def.id,
+        // TODO build*Sections() 的结果是动态的，需要单独给每一个 sections 保存一个缓存，
+        // 每次 build*Sections() 之后都更新缓存，搜索时直接使用缓存。
         strings: getTabSearchStrings(def.id),
     }));
     const inputElement = element.querySelector(".b3-form__icon input") as HTMLInputElement;
@@ -294,7 +296,7 @@ export const initConfigSearch = (element: HTMLElement, app: App) => {
                 }
                 // TODO 在把所有设置项都改成注册式之后，把 .toLowerCase() 移到对应的收集文案的函数里只处理一次，而不是在这里反复处理
                 // TODO 预先将含 HTML 的文案转为纯文本（比如 innerText 或 textContent），避免命中 HTML 标签中的文本（例如搜索 "code" 会命中包含 <code> 标签的文案）
-                if (textMatchesConfigSearch(subItem, keywords)) {
+                if (textMatchesSearch(subItem, keywords)) {
                     matchedTabIds.add(id);
                     break;
                 }

app/src/config/ui/search.ts

@@ -31,7 +31,7 @@ const stackExtraSearchStrings = (row: SettingRowStack): string[] => {
 };
 
 /** 设置面板内搜索：单条文案是否包含查询串（已 `trim` + `toLowerCase` 的 `queryLower`） */
-export const textMatchesConfigSearch = (text: string, queryLower: string): boolean => {
+export const textMatchesSearch = (text: string, queryLower: string): boolean => {
     if (!queryLower) {
         return true;
     }
@@ -52,40 +52,40 @@ export const configRowMatchesSearchQuery = (row: SettingRow, queryLower: string)
         case "range":
         case "notebookSavePath":
             return (
-                textMatchesConfigSearch(row.title, queryLower) ||
-                textMatchesConfigSearch(row.desc, queryLower)
+                textMatchesSearch(row.title, queryLower) ||
+                textMatchesSearch(row.desc, queryLower)
             );
         case "number":
             if (
-                textMatchesConfigSearch(row.title, queryLower) ||
-                textMatchesConfigSearch(row.desc, queryLower)
+                textMatchesSearch(row.title, queryLower) ||
+                textMatchesSearch(row.desc, queryLower)
             ) {
                 return true;
             }
-            if (row.unit && textMatchesConfigSearch(row.unit, queryLower)) {
+            if (row.unit && textMatchesSearch(row.unit, queryLower)) {
                 return true;
             }
             return false;
         case "select":
             if (
-                textMatchesConfigSearch(row.title, queryLower) ||
-                textMatchesConfigSearch(row.desc, queryLower)
+                textMatchesSearch(row.title, queryLower) ||
+                textMatchesSearch(row.desc, queryLower)
             ) {
                 return true;
             }
-            return row.options.some((o) => textMatchesConfigSearch(o.label ?? String(o.value), queryLower));
+            return row.options.some((o) => textMatchesSearch(o.label ?? String(o.value), queryLower));
         case "button":
             return (
-                textMatchesConfigSearch(row.title, queryLower) ||
-                textMatchesConfigSearch(row.label, queryLower) ||
-                (row.desc ? textMatchesConfigSearch(row.desc, queryLower) : false)
+                textMatchesSearch(row.title, queryLower) ||
+                textMatchesSearch(row.label, queryLower) ||
+                (row.desc ? textMatchesSearch(row.desc, queryLower) : false)
             );
         case "custom":
-            return row.keywords.some((k) => textMatchesConfigSearch(k, queryLower));
+            return row.keywords.some((k) => textMatchesSearch(k, queryLower));
         case "switchQuery":
-            return switchQuerySearchStrings(row).some((s) => textMatchesConfigSearch(s, queryLower));
+            return switchQuerySearchStrings(row).some((s) => textMatchesSearch(s, queryLower));
         case "stack":
-            return stackExtraSearchStrings(row).some((s) => textMatchesConfigSearch(s, queryLower));
+            return stackExtraSearchStrings(row).some((s) => textMatchesSearch(s, queryLower));
     }
 };
 
@@ -135,7 +135,7 @@ export const filterSettingSections = <T extends {title?: string; items: SettingR
     }
     const out: T[] = [];
     for (const section of sections) {
-        if (textMatchesConfigSearch(section.title ?? "", queryLower)) {
+        if (textMatchesSearch(section.title ?? "", queryLower)) {
             out.push(section);
             continue;
         }