Add warning if hook install directory does not exist.

Use assertSame rather than assertEquals where possible.

Author: Sam Parkinson

src/Command/HookInstallCommand.php

@@ -45,17 +45,23 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $force  = $input->getOption('force');
 
         if ($output->isVeryVerbose()) {
-            $message = sprintf('<info>Using %s for the hook target.</info>', $target);
+            $message = sprintf('<info>Using %s for the install path.</info>', $link);
             $output->writeln($message);
 
-            $message = sprintf('<info>Using %s for the hook.</info>', $link);
+            $message = sprintf('<info>Using %s as the hook.</info>', $target);
             $output->writeln($message);
         }
 
+        if (! is_dir(dirname($link))) {
+            $message = sprintf('<error>The directory at %s does not exist.</error>', $link);
+            $output->writeln($message);
+            exit(1);
+        }
+
         if (file_exists($link) && $force) {
             unlink($link);
 
-            $message = sprintf('<info>Removed existing file at %s.</info>', $link);
+            $message = sprintf('<comment>Removed existing file at %s.</comment>', $link);
             $output->writeln($message);
         }
 

tests/unit/Collection/CollectionTest.php

@@ -40,7 +40,7 @@ public function testConstructorWithArgument()
         $this->collection->__construct($items);
 
         for ($i = 0; $i > count($this->collection); $i++) {
-            $this->assertEquals($items[$i], $this->collection[$i]);
+            $this->assertSame($items[$i], $this->collection[$i]);
         }
     }
 
@@ -62,12 +62,12 @@ public function testAppendWithValidItem()
         $this->collection->append($item);
 
         $this->assertCount(1, $this->collection);
-        $this->assertEquals($item, $this->collection->current());
+        $this->assertSame($item, $this->collection->current());
 
         $this->collection->append($item);
 
         $this->assertCount(2, $this->collection);
-        $this->assertEquals($item, $this->collection->next());
+        $this->assertSame($item, $this->collection->next());
     }
 
     /**

tests/unit/Collection/IssueCollectionTest.php

@@ -87,7 +87,7 @@ public function testForLevelWithMatchingLevel()
         $issues = $this->collection->forLevel(Issue::LEVEL_INFO);
 
         $this->assertCount(1, $issues);
-        $this->assertEquals($issue, $issues->current());
+        $this->assertSame($issue, $issues->current());
     }
 
     public function testForLevelWithNonMatchingLevel()

tests/unit/Collection/ReviewCollectionTest.php

@@ -88,7 +88,7 @@ public function testForFileWithMatchingFile()
         $reviews = $this->collection->forFile($file);
 
         $this->assertCount(1, $reviews);
-        $this->assertEquals($review, $reviews->current());
+        $this->assertSame($review, $reviews->current());
     }
 
     public function testForFileWithNonMatchingFile()

tests/unit/File/FileTest.php

@@ -42,19 +42,19 @@ public function testGetFileName()
     {
         $expected = 'file.php';
 
-        $this->assertEquals($expected, $this->file->getFileName());
+        $this->assertSame($expected, $this->file->getFileName());
     }
 
     public function testGetRelativePath()
     {
-        $this->assertEquals($this->filePath, $this->file->getRelativePath());
+        $this->assertSame($this->filePath, $this->file->getRelativePath());
     }
 
     public function testGetFullPathWithNoCachedPath()
     {
         $expected = $this->projectPath . '/' . $this->filePath;
 
-        $this->assertEquals($expected, $this->file->getFullPath());
+        $this->assertSame($expected, $this->file->getFullPath());
     }
 
     public function testGetFullPathWithCachedPath()
@@ -63,7 +63,7 @@ public function testGetFullPathWithCachedPath()
 
         $this->file->setCachedPath($path);
 
-        $this->assertEquals($path, $this->file->getFullPath());
+        $this->assertSame($path, $this->file->getFullPath());
     }
 
     public function testGetCachedPath()
@@ -74,7 +74,7 @@ public function testGetCachedPath()
 
         $result = $this->file->setCachedPath($path);
 
-        $this->assertEquals($path, $this->file->getCachedPath());
+        $this->assertSame($path, $this->file->getCachedPath());
     }
 
     public function testSetCachedPath()
@@ -83,21 +83,21 @@ public function testSetCachedPath()
 
         $path = '/Test';
 
-        $this->assertEquals($this->file,  $this->file->setCachedPath($path));
+        $this->assertSame($this->file,  $this->file->setCachedPath($path));
 
-        $this->assertEquals($path, $this->file->getCachedPath());
+        $this->assertSame($path, $this->file->getCachedPath());
     }
 
     public function testGetExtension()
     {
         $expected = pathinfo($this->filePath, PATHINFO_EXTENSION);
 
-        $this->assertEquals($expected, $this->file->getExtension());
+        $this->assertSame($expected, $this->file->getExtension());
     }
 
     public function testGetStatus()
     {
-        $this->assertEquals($this->fileStatus, $this->file->getStatus());
+        $this->assertSame($this->fileStatus, $this->file->getStatus());
     }
 
     public function testGetFormattedStatus()

tests/unit/Issue/IssueTest.php

@@ -51,22 +51,22 @@ public function tearDown()
 
     public function testGetLevel()
     {
-        $this->assertEquals($this->issueLevel, $this->issue->getLevel());
+        $this->assertSame($this->issueLevel, $this->issue->getLevel());
     }
 
     public function testGetMessage()
     {
-        $this->assertEquals($this->issueMessage, $this->issue->getMessage());
+        $this->assertSame($this->issueMessage, $this->issue->getMessage());
     }
 
     public function testGetReviewName()
     {
-        $this->assertEquals('ReviewInterface', $this->issue->getReviewName());
+        $this->assertSame('ReviewInterface', $this->issue->getReviewName());
     }
 
     public function testGetFile()
     {
-        $this->assertEquals($this->issueFile, $this->issue->getFile());
+        $this->assertSame($this->issueFile, $this->issue->getFile());
     }
 
     public function testGetLevelName()

tests/unit/Reporter/ReporterTest.php

@@ -49,7 +49,7 @@ public function testInfo()
 
         $this->assertCount(1, $issues);
 
-        $this->assertEquals(Issue::LEVEL_INFO, $issues->current()->getLevel());
+        $this->assertSame(Issue::LEVEL_INFO, $issues->current()->getLevel());
     }
 
     public function testWarning()
@@ -60,7 +60,7 @@ public function testWarning()
 
         $this->assertCount(1, $issues);
 
-        $this->assertEquals(Issue::LEVEL_WARNING, $issues->current()->getLevel());
+        $this->assertSame(Issue::LEVEL_WARNING, $issues->current()->getLevel());
     }
 
     public function testError()
@@ -71,7 +71,7 @@ public function testError()
 
         $this->assertCount(1, $issues);
 
-        $this->assertEquals(Issue::LEVEL_ERROR, $issues->current()->getLevel());
+        $this->assertSame(Issue::LEVEL_ERROR, $issues->current()->getLevel());
     }
 
     public function testHasIssues()
@@ -101,7 +101,7 @@ public function testGetIssues()
         $this->assertCount(3, $this->reporter->getIssues());
 
         foreach($this->reporter->getIssues() as $issue) {
-            $this->assertEquals('Test', $issue->getMessage());
+            $this->assertSame('Test', $issue->getMessage());
         }
     }
 }

tests/unit/StaticReviewTest.php

@@ -42,16 +42,16 @@ public function tearDown()
 
     public function testGetReporter()
     {
-        $this->assertEquals($this->reporter, $this->staticReview->getReporter());
+        $this->assertSame($this->reporter, $this->staticReview->getReporter());
     }
 
     public function testSetReporter()
     {
         $newReporter = Mockery::mock('StaticReview\Reporter\ReporterInterface');
 
-        $this->assertEquals($this->staticReview, $this->staticReview->setReporter($newReporter));
+        $this->assertSame($this->staticReview, $this->staticReview->setReporter($newReporter));
 
-        $this->assertEquals($newReporter, $this->staticReview->getReporter());
+        $this->assertSame($newReporter, $this->staticReview->getReporter());
     }
 
     public function testGetReviews()
@@ -67,7 +67,7 @@ public function testAddReview()
     {
         $this->assertCount(0, $this->staticReview->getReviews());
 
-        $this->assertEquals($this->staticReview, $this->staticReview->addReview($this->review));
+        $this->assertSame($this->staticReview, $this->staticReview->addReview($this->review));
         $this->assertCount(1, $this->staticReview->getReviews());
     }
 
@@ -77,7 +77,7 @@ public function testAddReviews()
 
         $reviews = new ReviewCollection([$this->review, $this->review]);
 
-        $this->assertEquals($this->staticReview, $this->staticReview->addReviews($reviews));
+        $this->assertSame($this->staticReview, $this->staticReview->addReviews($reviews));
         $this->assertCount(2, $this->staticReview->getReviews());
     }
 
@@ -94,6 +94,6 @@ public function testReview()
 
         $this->staticReview->addReviews($reviews);
 
-        $this->assertEquals($this->staticReview, $this->staticReview->review($files));
+        $this->assertSame($this->staticReview, $this->staticReview->review($files));
     }
 }