From 8e984a7cadbed8a0c7b52e53c8aaca2d71920624 Mon Sep 17 00:00:00 2001 From: FineFindus Date: Fri, 9 Feb 2024 23:13:50 +0100 Subject: [PATCH 1/2] feat: inline avatars for reblogline --- .../ReblogOrReplyLineStatusDisplayItem.java | 11 ++++ .../android/ui/text/AvatarSpan.java | 50 +++++++++++++++++++ .../android/ui/text/CustomEmojiSpan.java | 2 +- 3 files changed, 62 insertions(+), 1 deletion(-) create mode 100644 mastodon/src/main/java/org/joinmastodon/android/ui/text/AvatarSpan.java diff --git a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java index 84df641a1d..5244de4205 100644 --- a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java +++ b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java @@ -7,6 +7,7 @@ import android.graphics.drawable.Drawable; import android.os.Build; import android.text.SpannableStringBuilder; +import android.text.Spanned; import android.util.TypedValue; import android.view.View; import android.view.ViewGroup; @@ -18,7 +19,10 @@ import org.joinmastodon.android.model.Emoji; import org.joinmastodon.android.model.Status; import org.joinmastodon.android.model.StatusPrivacy; +import org.joinmastodon.android.ui.text.AvatarSpan; +import org.joinmastodon.android.ui.text.CustomEmojiSpan; import org.joinmastodon.android.ui.text.HtmlParser; +import org.joinmastodon.android.ui.text.SpacerSpan; import org.joinmastodon.android.ui.utils.CustomEmojiHelper; import org.joinmastodon.android.ui.utils.UiUtils; @@ -53,6 +57,13 @@ public ReblogOrReplyLineStatusDisplayItem(String parentID, BaseStatusListFragmen SpannableStringBuilder ssb=new SpannableStringBuilder(text); if(AccountSessionManager.get(parentFragment.getAccountID()).getLocalPreferences().customEmojiInNames) HtmlParser.parseCustomEmoji(ssb, emojis); + + if(status.reblog!=null){ + //add temp chars for span replacement, should be same as spans added below + ssb.insert(0, " "); + ssb.setSpan(new AvatarSpan(status.account), 0, 1, Spanned.SPAN_INCLUSIVE_EXCLUSIVE); + ssb.setSpan(new SpacerSpan(15, 20), 1, 2, Spanned.SPAN_INCLUSIVE_EXCLUSIVE); + } this.text=ssb; emojiHelper.setText(ssb); this.fullText=fullText; diff --git a/mastodon/src/main/java/org/joinmastodon/android/ui/text/AvatarSpan.java b/mastodon/src/main/java/org/joinmastodon/android/ui/text/AvatarSpan.java new file mode 100644 index 0000000000..1fdbcb06d6 --- /dev/null +++ b/mastodon/src/main/java/org/joinmastodon/android/ui/text/AvatarSpan.java @@ -0,0 +1,50 @@ +package org.joinmastodon.android.ui.text; + +import android.graphics.Canvas; +import android.graphics.Paint; +import android.graphics.Path; +import android.graphics.Rect; +import android.graphics.drawable.Drawable; +import android.text.style.ReplacementSpan; + +import org.joinmastodon.android.GlobalUserPreferences; +import org.joinmastodon.android.model.Account; +import org.joinmastodon.android.model.Emoji; + +import androidx.annotation.NonNull; +import androidx.annotation.Nullable; +import me.grishka.appkit.imageloader.requests.UrlImageLoaderRequest; +import me.grishka.appkit.utils.V; + +public class AvatarSpan extends CustomEmojiSpan{ + + public AvatarSpan(Account account){ + //this is a hacky solution to allow loading of avatars in the middle of strings, + //using already existing code for loading emojis + super(new Emoji(account.avatarStatic, account.avatar, account.avatarStatic)); + } + + @Override + public void draw(@NonNull Canvas canvas, CharSequence text, int start, int end, float x, int top, int y, int bottom, @NonNull Paint paint){ + //modified draw of a CustomEmojiSpan, drawing a circular image instead. + if(drawable==null) + return; + int size=Math.round(paint.descent()-paint.ascent()); + Rect bounds=drawable.getBounds(); + int dw=drawable.getIntrinsicWidth(); + int dh=drawable.getIntrinsicHeight(); + if(bounds.left!=0 || bounds.top!=0 || bounds.right!=dw || bounds.left!=dh){ + drawable.setBounds(0, 0, dw, dh); + } + canvas.save(); + float radius = size / 2f; + Path clipPath = new Path(); + clipPath.addCircle(x + radius, top + radius, radius, Path.Direction.CW); + canvas.clipPath(clipPath); + canvas.translate(x, top); + canvas.scale(size/(float)dw, size/(float)dh, 0f, 0f); + drawable.draw(canvas); + canvas.restore(); + } + +} diff --git a/mastodon/src/main/java/org/joinmastodon/android/ui/text/CustomEmojiSpan.java b/mastodon/src/main/java/org/joinmastodon/android/ui/text/CustomEmojiSpan.java index b6732b31cb..c72ff8f8a9 100644 --- a/mastodon/src/main/java/org/joinmastodon/android/ui/text/CustomEmojiSpan.java +++ b/mastodon/src/main/java/org/joinmastodon/android/ui/text/CustomEmojiSpan.java @@ -16,7 +16,7 @@ public class CustomEmojiSpan extends ReplacementSpan{ public final Emoji emoji; - private Drawable drawable; + protected Drawable drawable; public CustomEmojiSpan(Emoji emoji){ this.emoji=emoji; From 72940832a6240c03462b7ed2f70063110820e3e3 Mon Sep 17 00:00:00 2001 From: FineFindus Date: Sat, 10 Feb 2024 13:55:31 +0100 Subject: [PATCH 2/2] fix(ReblogOrReplyLineStatusDisplayItem): only display avatar for bossting --- .../ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java index 5244de4205..3a1158c00f 100644 --- a/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java +++ b/mastodon/src/main/java/org/joinmastodon/android/ui/displayitems/ReblogOrReplyLineStatusDisplayItem.java @@ -58,7 +58,7 @@ public ReblogOrReplyLineStatusDisplayItem(String parentID, BaseStatusListFragmen if(AccountSessionManager.get(parentFragment.getAccountID()).getLocalPreferences().customEmojiInNames) HtmlParser.parseCustomEmoji(ssb, emojis); - if(status.reblog!=null){ + if(status.reblog!=null&&handleClick!=null){ //add temp chars for span replacement, should be same as spans added below ssb.insert(0, " "); ssb.setSpan(new AvatarSpan(status.account), 0, 1, Spanned.SPAN_INCLUSIVE_EXCLUSIVE);