Skip to content

Commit cea9fb4

Browse files
committed
fix slither and solhint warnings
1 parent 86ec59d commit cea9fb4

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

contracts/test/BiteMock.sol

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,6 @@ contract BiteMock is IBiteMock{
113113

114114
DoubleEndedQueue.Bytes32Deque private _queue;
115115

116-
/// @notice Emitted when a callback is removed
117-
/// @param senderAddress The address of the callback sender
118-
event CallbackRemoved(address indexed senderAddress);
119-
120116

121117
error NoCallbacksQueued();
122118
error CallbackDidNotRevert();
@@ -129,19 +125,20 @@ contract BiteMock is IBiteMock{
129125
/// @inheritdoc IBiteMock
130126
function removeNextCTXIfItReverts() external override {
131127
require(!_queue.empty(), NoCallbacksQueued());
128+
uint256 initLength = _queue.length();
132129
address payable senderAddress = payable(address(uint160(uint256(_queue.popFront()))));
133130

134131
try CallbackSender(senderAddress).sendCallback() {
135132
revert CallbackDidNotRevert();
136133
} catch {
137-
emit CallbackRemoved(senderAddress);
134+
assert(initLength > _queue.length());
138135
}
139136
}
140137

141138
/// @inheritdoc IBiteMock
142139
function removeNextCTX() external override {
143140
require(!_queue.empty(), NoCallbacksQueued());
144-
_queue.popFront();
141+
assert(_queue.popFront() != bytes32(0));
145142
}
146143

147144
/// @inheritdoc IBiteMock

0 commit comments

Comments
 (0)