Merge pull request #1766 from skaut/frontend-eslint-updates

marekdedic · web-flow · commit bce6e23c6f54 · 2025-01-13T21:53:28.000+01:00
[frontend] Updated eslint vitest ruleset
diff --git a/packages/frontend/eslint.config.js b/packages/frontend/eslint.config.js
@@ -234,7 +234,14 @@ export default tseslint.config(
       "vitest/prefer-comparison-matcher": "error",
       "vitest/prefer-each": "error",
       "vitest/prefer-equality-matcher": "error",
-      "vitest/prefer-expect-assertions": "error",
+      "vitest/prefer-expect-assertions": [
+        "error",
+        {
+          onlyFunctionsWithAsyncKeyword: true,
+          onlyFunctionsWithExpectInCallback: true,
+          onlyFunctionsWithExpectInLoop: true,
+        },
+      ],
       "vitest/prefer-expect-resolves": "error",
       "vitest/prefer-hooks-in-order": "error",
       "vitest/prefer-hooks-on-top": "error",
@@ -243,9 +250,7 @@ export default tseslint.config(
       "vitest/prefer-spy-on": "error",
       "vitest/prefer-strict-equal": "error",
       "vitest/prefer-to-be": "error",
-      "vitest/prefer-to-be-falsy": "error",
       "vitest/prefer-to-be-object": "error",
-      "vitest/prefer-to-be-truthy": "error",
       "vitest/prefer-to-contain": "error",
       "vitest/prefer-to-have-length": "error",
       "vitest/prefer-todo": "error",
diff --git a/packages/frontend/tests/App.test.tsx b/packages/frontend/tests/App.test.tsx
@@ -15,8 +15,6 @@ describe("App", () => {
   });
 
   test("should render correctly", () => {
-    expect.assertions(1);
-
     vi.mocked(swr).default.mockReturnValue({
       data: testData,
       error: undefined,
@@ -34,8 +32,6 @@ describe("App", () => {
   });
 
   test("should render projects correctly", () => {
-    expect.assertions(1);
-
     vi.mocked(swr).default.mockReturnValue({
       data: testData,
       error: undefined,
@@ -53,8 +49,6 @@ describe("App", () => {
   });
 
   test("should render project listing correctly", () => {
-    expect.assertions(1);
-
     vi.mocked(swr).default.mockReturnValue({
       data: testData,
       error: undefined,
@@ -72,8 +66,6 @@ describe("App", () => {
   });
 
   test("should render issue listing correctly", () => {
-    expect.assertions(1);
-
     vi.mocked(swr).default.mockReturnValue({
       data: testData,
       error: undefined,
@@ -91,8 +83,6 @@ describe("App", () => {
   });
 
   test("should handle error gracefully", () => {
-    expect.assertions(1);
-
     vi.mocked(swr).default.mockReturnValue({
       data: undefined,
       error: true,
diff --git a/packages/frontend/tests/components/AppNavigation.test.tsx b/packages/frontend/tests/components/AppNavigation.test.tsx
@@ -6,8 +6,6 @@ import { AppNavigation } from "../../src/components/AppNavigation";
 
 describe("AppNavigation component", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter>
         <AppNavigation />
diff --git a/packages/frontend/tests/components/Button.test.tsx b/packages/frontend/tests/components/Button.test.tsx
@@ -5,8 +5,6 @@ import { Button } from "../../src/components/Button";
 
 describe("Button component", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <Button href="http://www.somewhere.com">Link somewhere</Button>,
     );
@@ -15,8 +13,6 @@ describe("Button component", () => {
   });
 
   test("should render correctly with title", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <Button href="http://www.somewhere.com" title="myTitle">
         Link somewhere
@@ -27,8 +23,6 @@ describe("Button component", () => {
   });
 
   test("should render correctly with custom class", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <Button className="myClassName" href="http://www.somewhere.com">
         Link somewhere
@@ -39,8 +33,6 @@ describe("Button component", () => {
   });
 
   test("should render correctly with target self", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <Button href="http://www.somewhere.com" targetSelf>
         Link somewhere
diff --git a/packages/frontend/tests/components/ColoredTag.test.tsx b/packages/frontend/tests/components/ColoredTag.test.tsx
@@ -5,8 +5,6 @@ import { ColoredTag } from "../../src/components/ColoredTag";
 
 describe("ColoredTag component", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(<ColoredTag>Tag</ColoredTag>);
 
     expect(container.firstChild).toMatchSnapshot();
diff --git a/packages/frontend/tests/components/ExtLink.test.tsx b/packages/frontend/tests/components/ExtLink.test.tsx
@@ -5,8 +5,6 @@ import { ExtLink } from "../../src/components/ExtLink";
 
 describe("ExtLink component", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <ExtLink href="http://www.somewhere.com">Link somewhere</ExtLink>,
     );
@@ -15,8 +13,6 @@ describe("ExtLink component", () => {
   });
 
   test("should render correctly with title", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <ExtLink href="http://www.somewhere.com" title="myTitle">
         Link somewhere
@@ -27,8 +23,6 @@ describe("ExtLink component", () => {
   });
 
   test("should render correctly with custom class", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <ExtLink className="myClassName" href="http://www.somewhere.com">
         Link somewhere
@@ -39,8 +33,6 @@ describe("ExtLink component", () => {
   });
 
   test("should render correctly with target self", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <ExtLink href="http://www.somewhere.com" targetSelf>
         Link somewhere
diff --git a/packages/frontend/tests/components/Issue.test.tsx b/packages/frontend/tests/components/Issue.test.tsx
@@ -18,7 +18,6 @@ const issueWithProject = getIssueWithProject(
 
 describe("Issue component", () => {
   test("should render correctly", () => {
-    expect.assertions(2);
     expect(issue).not.toBeNull();
 
     const { container } = render(
@@ -31,8 +30,6 @@ describe("Issue component", () => {
   });
 
   test("should render correctly without tags", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter>
         <Issue hideTags issue={issueWithProject} />
diff --git a/packages/frontend/tests/components/IssuesList.test.tsx b/packages/frontend/tests/components/IssuesList.test.tsx
@@ -9,8 +9,6 @@ const project = testData.projects[0];
 
 describe("IssuesList component", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter>
         <IssuesList issues={project.issues} project={project} />
@@ -21,8 +19,6 @@ describe("IssuesList component", () => {
   });
 
   test("should render correctly without link", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter>
         <IssuesList
diff --git a/packages/frontend/tests/components/Navigation.test.tsx b/packages/frontend/tests/components/Navigation.test.tsx
@@ -6,8 +6,6 @@ import { Navigation } from "../../src/components/Navigation";
 
 describe("Navigation component", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter>
         <Navigation
@@ -29,8 +27,6 @@ describe("Navigation component", () => {
   });
 
   test("should render correctly with active item", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter>
         <Navigation
diff --git a/packages/frontend/tests/components/Project.test.tsx b/packages/frontend/tests/components/Project.test.tsx
@@ -9,8 +9,6 @@ const project = testData.projects[0];
 
 describe("Project component", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter>
         <Project project={project} />
diff --git a/packages/frontend/tests/components/ProjectLinks.test.tsx b/packages/frontend/tests/components/ProjectLinks.test.tsx
@@ -9,8 +9,6 @@ const project = testData.projects[0];
 
 describe("ProjectLinks component", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter>
         <ProjectLinks projectInfo={project.info} />
diff --git a/packages/frontend/tests/pages/IssueDetail.test.tsx b/packages/frontend/tests/pages/IssueDetail.test.tsx
@@ -10,8 +10,6 @@ const issue = project.issues[0];
 
 describe("IssueDetail page", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter
         initialEntries={[
@@ -31,8 +29,6 @@ describe("IssueDetail page", () => {
   });
 
   test("should render correctly if there is no related issue", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter initialEntries={[`/${project.owner}/${project.repo}/0`]}>
         <Routes>
diff --git a/packages/frontend/tests/pages/IssuesList.test.tsx b/packages/frontend/tests/pages/IssuesList.test.tsx
@@ -7,8 +7,6 @@ import { testData } from "../testData";
 
 describe("IssuesList page", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter>
         <IssuesList data={testData} />
diff --git a/packages/frontend/tests/pages/ProjectDetail.test.tsx b/packages/frontend/tests/pages/ProjectDetail.test.tsx
@@ -9,8 +9,6 @@ const project = testData.projects[0];
 
 describe("ProjectDetail page", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter initialEntries={[`/${project.owner}/${project.repo}`]}>
         <Routes>
@@ -26,8 +24,6 @@ describe("ProjectDetail page", () => {
   });
 
   test("should render correctly if there is no related issue", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter initialEntries={[`/owner/repo`]}>
         <Routes>
diff --git a/packages/frontend/tests/pages/ProjectsList.test.tsx b/packages/frontend/tests/pages/ProjectsList.test.tsx
@@ -7,8 +7,6 @@ import { testData } from "../testData";
 
 describe("ProjectsList page", () => {
   test("should render correctly", () => {
-    expect.assertions(1);
-
     const { container } = render(
       <MemoryRouter>
         <ProjectsList data={testData} />
diff --git a/packages/frontend/tests/utils/getAllIssues.test.ts b/packages/frontend/tests/utils/getAllIssues.test.ts
@@ -4,16 +4,12 @@ import { getIssuesWithProjectInfo } from "../../src/utils/getAllIssues";
 import { testData } from "../testData";
 
 test("should get all issues", () => {
-  expect.assertions(1);
-
   const result = getIssuesWithProjectInfo(testData);
 
   expect(result).toMatchSnapshot();
 });
 
 test("should all issues except one", () => {
-  expect.assertions(1);
-
   const result = getIssuesWithProjectInfo(testData, { omitIssueNumber: 5 });
 
   expect(result).toMatchSnapshot();
diff --git a/packages/frontend/tests/utils/getIssueLink.test.ts b/packages/frontend/tests/utils/getIssueLink.test.ts
@@ -4,8 +4,6 @@ import { getIssueLink } from "../../src/utils/getIssueLink";
 import { testData } from "../testData";
 
 test("should get issue link", () => {
-  expect.assertions(1);
-
   const project = testData.projects[0];
   const result = getIssueLink({
     project: { ...project, ...project.info },
diff --git a/packages/frontend/tests/utils/getIssueWithProject.test.ts b/packages/frontend/tests/utils/getIssueWithProject.test.ts
@@ -6,8 +6,6 @@ import { testData } from "../testData";
 const project = testData.projects[0];
 
 test("should get issue with project", () => {
-  expect.assertions(1);
-
   const result = getIssueWithProject(
     testData,
     project.owner,
@@ -19,8 +17,6 @@ test("should get issue with project", () => {
 });
 
 test("should not get issue with project if there is no existing owner", () => {
-  expect.assertions(1);
-
   const result = getIssueWithProject(
     testData,
     "",
@@ -32,8 +28,6 @@ test("should not get issue with project if there is no existing owner", () => {
 });
 
 test("should not get issue with project if there is no existing repo", () => {
-  expect.assertions(1);
-
   const result = getIssueWithProject(
     testData,
     project.owner,
@@ -45,8 +39,6 @@ test("should not get issue with project if there is no existing repo", () => {
 });
 
 test("should not get issue with project if there is no existing issue number", () => {
-  expect.assertions(1);
-
   const result = getIssueWithProject(testData, project.owner, project.repo, 99);
 
   expect(result).toBeUndefined();
diff --git a/packages/frontend/tests/utils/getProject.test.ts b/packages/frontend/tests/utils/getProject.test.ts
@@ -6,24 +6,18 @@ import { testData } from "../testData";
 const project = testData.projects[0];
 
 test("should get project", () => {
-  expect.assertions(1);
-
   const result = getProject(testData, project.owner, project.repo);
 
   expect(result).toMatchSnapshot();
 });
 
 test("should not get project if there is no existing owner", () => {
-  expect.assertions(1);
-
   const result = getProject(testData, "", project.repo);
 
   expect(result).toBeUndefined();
 });
 
 test("should not get project if there is no existing repo", () => {
-  expect.assertions(1);
-
   const result = getProject(testData, project.owner, "");
 
   expect(result).toBeUndefined();
diff --git a/packages/frontend/tests/utils/getProjectLink.test.ts b/packages/frontend/tests/utils/getProjectLink.test.ts
@@ -6,8 +6,6 @@ import { testData } from "../testData";
 const project = testData.projects[0];
 
 test("should get project link", () => {
-  expect.assertions(1);
-
   const result = getProjectLink(project);
 
   expect(result).toBe("/skaut/skaut-google-drive-gallery");
