bug for go-ts-mode

[jixiuf]

go these errors when using meow-tree-sitter in go-ts-mode

meow-tree-sitter--get-nodes: Query pattern is malformed: "Node type error at", 453, "(function_declaration
  body: (block)? @function.inside) @function.around

(func_literal
  (_)? @function.inside) @function.around

(method_declaration
  body: (block)? @function.inside) @function.around

;; struct and interface declaration as class textobject?
(type_declaration
  (type_spec (type_identifier) (struct_type (field_declaration_list (_)?) @class.inside))) @class.around

(type_declaration
  (type_spec (type_identifier) (interface_type (method_spec)+ @class.inside))) @class.around

(type_parameter_list
  ((_) @parameter.inside . \",\"? @parameter.around) @parameter.around)

(parameter_list
  ((_) @parameter.inside . \",\"? @parameter.around) @parameter.around)

(argument_list
  ((_) @parameter.inside . \",\"? @parameter.around) @parameter.around)

(comment) @comment.inside

(comment)+ @comment.around

((function_declaration
   name: (identifier) @_name
   body: (block)? @test.inside) @test.around
 (#match \"^Test\" @_name))
", "Debug the query with `treesit-query-validate'"

[skissue]

Can't seem to reproduce this when testing with just treesit (I don't use Meow anymore, so I don't have this package installed to test off the cuff). What version of Emacs are you using? Could you open the queries/go.scm file in this repository in Emacs and try evaluating (treesit-query-validate 'go (buffer-string)) to see if it considers the query valid?

[jixiuf]

Node type error at: 453
(function_declaration
  body: (block)? @function.inside) @function.around

(func_literal
  (_)? @function.inside) @function.around

(method_declaration
  body: (block)? @function.inside) @function.around

;; struct and interface declaration as class textobject?
(type_declaration
  (type_spec (type_identifier) (struct_type (field_declaration_list (_)?) @class.inside))) @class.around

(type_declaration
  (type_spec (type_identifier) (interface_type (method_spec)+ @class.inside))) @class.around

(type_parameter_list
  ((_) @parameter.inside . ","? @parameter.around) @parameter.around)

(parameter_list
  ((_) @parameter.inside . ","? @parameter.around) @parameter.around)

(argument_list
  ((_) @parameter.inside . ","? @parameter.around) @parameter.around)

(comment) @comment.inside

(comment)+ @comment.around

((function_declaration
   name: (identifier) @_name
   body: (block)? @test.inside) @test.around
 (#match "^Test" @_name))

I build emacs from the scratch/igc branch

[skissue]

I build emacs from the scratch/igc branch

Could you please test on one of the mainline branches (29 or 30)? It seems like this syntax should be allowed according to "String patterns" under this section of the manual.

[jixiuf]

It doesn't work on 29.4

[elken]

I can also confirm this errors on both latest release Emacs and a recent master build.

I'm not a Go user, but the below seems to fix for me

@@ -9,10 +9,19 @@
 
 ;; struct and interface declaration as class textobject?
 (type_declaration
-  (type_spec (type_identifier) (struct_type (field_declaration_list (_)?) @class.inside))) @class.around
+  (type_spec
+    type: (struct_type
+      (field_declaration_list) @class.inner))) @class.around
+
+(struct_type
+  (field_declaration_list) @class.inner) @class.around
 
 (type_declaration
-  (type_spec (type_identifier) (interface_type (method_spec)+ @class.inside))) @class.around
+  (type_spec
+    type: (struct_type
+      (field_declaration_list
+        (field_declaration
+         type: (function_type) @function.inner))))) @function.around
 
 (type_parameter_list
   ((_) @parameter.inside . ","? @parameter.around) @parameter.around)

[skissue]

Sorry for the delay! Should be fixed now. Thanks @elken!