remove detatch

Author: mnseok

src/killer.c

@@ -11,12 +11,7 @@ void *timeout_killer(void *timeout_killer_args) {
     // this is a new thread, kill the process if timeout
     pid_t pid = ((struct timeout_killer_args *)timeout_killer_args)->pid;
     int timeout = ((struct timeout_killer_args *)timeout_killer_args)->timeout;
-    // On success, pthread_detach() returns 0; on error, it returns an error
-    // number.
-    if (pthread_detach(pthread_self()) != 0) {
-        kill_pid(pid);
-        return NULL;
-    }
+
     // usleep can't be used, for time args must < 1000ms
     // this may sleep longer that expected, but we will have a check at the end
     if (sleep((unsigned int)((timeout + 1000) / 1000)) != 0) {

src/runner.c

@@ -115,11 +115,12 @@ void run(struct config *_config, struct result *_result) {
 
         // process exited, we may need to cancel timeout killer thread
         if (_config->max_real_time != UNLIMITED) {
-            if (_result->real_time < _config->max_real_time) {
-                if (pthread_cancel(tid) != 0) {
-                    // todo logging
-                };
-            }
+            if (pthread_cancel(tid) != 0) {
+                // todo logging
+            };
+            if (pthread_join(tid, NULL) != 0) {
+                // todo logging
+            };
         }
 
         if (WIFSIGNALED(status) != 0) {