Skip to content

Commit b313f77

Browse files
authored
Add functional review process description (#334)
1 parent 925a578 commit b313f77

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

CONTRIBUTING.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,15 @@ After leaving those comments the reviewer removes their own assignment and lets
184184
After that the reviewer might be reassigned for a new review.
185185
If everything works as expected, the reviewer posts a +1 comment on the issue, approves the PR, removes their assignment and adds the suggested code reviewer as assignee and reviewer of the linked pull request.
186186

187+
The concrete process for functional review at https://test.skohub.io looks like this:
188+
189+
1. We merge the feature branches into the `dev` branch.
190+
2. This triggers a rebuild of test.skohub.io based on the `dev` branch.
191+
3. If needed, the reviewer adds or adjusts some vocabs in the [testing-skohub-vocabs repo](https://github.com/skohub-io/testing-skohub-vocabs) or otherwise only triggers a re-build with an empty commit (`$ git commit --allow-empty -m "Trigger webhook"').
192+
4. The reviewer does the functional review on the resulting test build at build]https://test.skohub.io/skohub-io/testing-skohub-vocabs/heads/main/.
193+
5. If needed, adustments are made in the feature branch and back to 1.).
194+
6. If the changes are functionally approved, the code review can follow.
195+
187196
##### Code Review
188197

189198
In code review, the technical implementation of the bugfix or the new feature is reviewed.

0 commit comments

Comments
 (0)